Skip to content

1584 floating point problems when using DynamicNPIs with optimal control in ODE model#1585

Merged
mknaranja merged 2 commits into
mainfrom
1584-floating-point-problems-when-using-dynamic-dampings-with-optimal-control-in-ode-model
Jul 23, 2026
Merged

1584 floating point problems when using DynamicNPIs with optimal control in ODE model#1585
mknaranja merged 2 commits into
mainfrom
1584-floating-point-problems-when-using-dynamic-dampings-with-optimal-control-in-ode-model

Conversation

@MaxBetzDLR

@MaxBetzDLR MaxBetzDLR commented Jul 23, 2026

Copy link
Copy Markdown
Member

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • When using DynamicNPIs with optimal control, the current setting could lead to extraordinarily small last time steps

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1584

@MaxBetzDLR
MaxBetzDLR requested a review from HenrZu July 23, 2026 09:24
@MaxBetzDLR MaxBetzDLR self-assigned this Jul 23, 2026
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (571e7bb) to head (c92fba9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
+ Coverage   97.44%   97.47%   +0.02%     
==========================================
  Files         190      190              
  Lines       16030    16030              
==========================================
+ Hits        15621    15625       +4     
+ Misses        409      405       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mknaranja mknaranja changed the title 1584 floating point problems when using dynamic dampings with optimal control in ode model 1584 floating point problems when using DynamicNPIs with optimal control in ODE model Jul 23, 2026
@mknaranja

Copy link
Copy Markdown
Member

Ok, with this minimal change, it is effectively only avoiding one last minimally-sized step. The remaining changes are just for correctness / explicitness of the template deduction if I am not mistaken. What do you think @HenrZu ?

@mknaranja
mknaranja merged commit 9ba8d03 into main Jul 23, 2026
64 checks passed
@mknaranja
mknaranja deleted the 1584-floating-point-problems-when-using-dynamic-dampings-with-optimal-control-in-ode-model branch July 23, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Floating point problems when using dynamic dampings with optimal control in ode model

3 participants