Declare and document developer interfaces - #133
Conversation
|
CI infrastructure blocker on the validated tree:
Maintainer action required: restore/restart the self-hosted runner and rerun the failed core jobs. No source change is warranted for these failures. |
920a7b0 to
3d92f7e
Compare
|
Final focused SHA
Maintainer action required: restore/restart the self-hosted runner, then rerun the three failed core jobs. Further source or empty-commit retries would not address this infrastructure failure. |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
3d92f7e to
41d4406
Compare
|
Rebased onto current RebaseSingle conflict, in
The three failed core jobs were an 8 GB runner-pool problem, not this PRCorrecting my earlier comment, which called it a generic "runner lost communication" and asked for a rerun without saying why. Evidence:
No source change was needed for this; the rebase re-runs CI on the 16 GB pool. Local validation of
|
Ignore this PR until reviewed by @ChrisRackauckas.
Prerequisite #132 is merged. This branch is rebased onto
eb4bf95(currentmain, which includes #134) and contains one focused audit commit.Summary
solvemethods at their definition sites, and render the canonical signatures in the manual.>= 2.4, remove broad QA exceptions, and synchronize root test extras/targets.mainto 1.2.4; 1.3.0 supersedes it and is the correct minor bump.)Verification
Local, on the rebased head
41d4406:Core, Julia 1.12.6 —
JULIA_NUM_THREADS=4 julia --project=. -e 'using Pkg; Pkg.test()':Core, Julia 1.10.11 (LTS), same command:
QA —
GROUP=QA julia --project=. -e 'using Pkg; Pkg.test()':Docs, strict —
CI=true julia --project=docs docs/make.jl, exit 0:Runic 1.7.0: clean over all 52 tracked
.jlfiles.typos: clean.git diff --check: clean.CI on
41d4406is fully green, including the three core jobs that previously failed: https://github.com/SciML/FiniteVolumeMethod.jl/actions/runs/31217120410 (Core julia 1 1h14m50s, Core lts 53m53s, Core pre 1h43m17s, QA 11m30s), plus Documentation, Downgrade, Runic, and Spell Check.About the earlier core-job failures
The three core failures on the previous head
3d92f7ewere an 8 GB runner-pool problem, not a defect here. All three ran onself-hosted-4vcpu-8gb-nh4np-*, died mid-Run tests(step conclusionnull), and never uploaded logs (BlobNotFound). Unmodifiedmainfailed the same way on the same pool the same day (https://github.com/SciML/FiniteVolumeMethod.jl/actions/runs/31102010097), and passes now that the pool is4vcpu-16gb. Locally the core test process reaches ~6.7 GiB RSS on Julia 1.12.6 — no headroom on an 8 GB runner. No source change was needed; the rebase re-ran CI on the 16 GB pool. Detail: #133 (comment)What a reviewer should push back on
publiclist insrc/FiniteVolumeMethod.jlis declared viaeval(Expr(:public, ...))behind aVERSION >= v"1.11.0-DEV.469"guard, because Julia 1.10 cannot parse apublicstatement. This makes those names public API on 1.11+ only, and locks the package into supporting them going forward.@doc raw"""docstrings insrc/specific_problems/abstract_templates.jlbecame plain"""with escaped LaTeX backslashes. Equivalent output, larger diff.[extras]/[targets]now mirrortest/Project.toml.test/Project.tomlstill takes precedence forPkg.test(); the root entries exist to satisfy Aqua's project-extras check. They are two lists that must be kept in sync.Not verified locally
DOCUMENTER_KEY). Note that deploy currently fails onmainateb4bf95withGit failed to fetch git@github.com:SciML/FiniteVolumeMethod.jl(https://github.com/SciML/FiniteVolumeMethod.jl/actions/runs/31197940930) — a pre-existing credential problem unrelated to this PR. The build itself passes here.Clean-main findings
origin/mainlocal documentation generation failure is tracked separately in Local docs generation fails on multiline Literate #src blocks #131.MatrixOperatorload regression begins with SciMLBase commit8e770b8d8a4bf0fc7d5c3d2909139fb275ab335d(SciMLBase#1476); the focused owner-import fix merged in Fix strict documentation build prerequisites #132.