Check arity of :path method #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
habemus-papadum
force-pushed
the
patch-1
branch
from
f647470 to
6813a10
Compare
|
Thank you @habemus-papadum Yes, that's right. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 4, 2021
0.5.0 (2021-03-25)
Bug Fixes:
* Fix Jupyter console crashes issue
SciRuby/iruby#210 (@kojix2)
* Fix syntax highlighting issue on Jpyter Lab
SciRuby/iruby#224 (@kojix2)
* Fix interoperability issue with ruby-git
SciRuby/iruby#139 (@habemus-papadum)
* Fix the issue of `$stderr.write` that cannot handle multiple arguments
SciRuby/iruby#206 (@kojix2)
* Remove a buggy `inspect_request` implementation
SciRuby/iruby#119 (@LunarLanding)
* Fix uninitialized constant `Fiddle` caused in initialization phase
SciRuby/iruby#264 (@MatthewSteen, @kjoix2)
* Fix the issue on displaying a table
SciRuby/iruby#281 (@ankane)
Enhancements:
* Add `IRuby.clear_output` method
SciRuby/iruby#220 (@kojix2)
* Make backtrace on exception simplify and more appropriate for code in a
cell SciRuby/iruby#249 (@zheng-yongping)
* Make syntax error message more appropriate
SciRuby/iruby#251 (@zheng-yongping)
* Remove top-level `In` and `Out` constants
SciRuby/iruby#229 (@kojix2)
* Use text/plain for the default format of `Numo::NArray` objects
SciRuby/iruby#255 (@kojix2)
* Use ffi-rzmq as the default ZeroMQ adapter
SciRuby/iruby#256 (@kojix2)
* Drop rbczmq support SciRuby/iruby#260
(@rstammer)
* Add ruby-vips image support SciRuby/iruby#279
(@ankane)
* Replace mimemagic with mime-types
SciRuby/iruby#291 (@mrkn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this arity check, display errors can result (for instance, many of the objects defined in the
ruby-gitgem define a.pathmethod requiring exactly one argument.)Note: It is questionable whether the the entire idea of supporting
.pathis wise... this PR attempts a minimal fix, but I would also suggest the maintainers consider simply removing the logic all together.