Skip to content

Conversation

zheng-yongping
Copy link
Contributor

  1. error message line number
    before:
    image
    image
    image
    after:
    image
    image
    image

  2. error message backtrace
    before:
    image
    after:
    image

@kojix2
Copy link
Member

kojix2 commented Sep 15, 2019

Hello @zheng-yongping
Thank you for your pull request.
I think the new feature looks good.
Let us check a little more.

#142

ping @mrkn

@mrkn mrkn merged commit 42c7362 into SciRuby:master Sep 15, 2019
@zheng-yongping
Copy link
Contributor Author

@kojix2
Sorry, my code depends on ruby2.6’s new infinite range syntax, it doesn't work well with ruby2.5.

https://github.com/zheng-yongping/iruby/blob/ac9763bbde4c7ce84c593cc376da2233c65e42c1/lib/iruby/kernel.rb#L108

when rindex return nil => ArgumentError (bad value for range)

What should I do?

@kojix2
Copy link
Member

kojix2 commented Sep 16, 2019

@zheng-yongping

You are right.
For Ruby 2.5 and earlier, we must check nil.
why don't you add some commits to your branch and make a pull request again?

@mrkn
Copy link
Contributor

mrkn commented Sep 16, 2019

@zheng-yongping Could you please make a new pull request to fix it?

@zheng-yongping
Copy link
Contributor Author

@kojix2 @mrkn
Sorry, I am new to GitHub and don't know if I should make a new pull request.

Here is the fix.
#250

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 4, 2021
0.5.0 (2021-03-25)

Bug Fixes:

  * Fix Jupyter console crashes issue
    SciRuby/iruby#210 (@kojix2)
  * Fix syntax highlighting issue on Jpyter Lab
    SciRuby/iruby#224 (@kojix2)
  * Fix interoperability issue with ruby-git
    SciRuby/iruby#139 (@habemus-papadum)
  * Fix the issue of `$stderr.write` that cannot handle multiple arguments
    SciRuby/iruby#206 (@kojix2)
  * Remove a buggy `inspect_request` implementation
    SciRuby/iruby#119 (@LunarLanding)
  * Fix uninitialized constant `Fiddle` caused in initialization phase
    SciRuby/iruby#264 (@MatthewSteen, @kjoix2)
  * Fix the issue on displaying a table
    SciRuby/iruby#281 (@ankane)

Enhancements:

  * Add `IRuby.clear_output` method
    SciRuby/iruby#220 (@kojix2)
  * Make backtrace on exception simplify and more appropriate for code in a
    cell SciRuby/iruby#249 (@zheng-yongping)
  * Make syntax error message more appropriate
    SciRuby/iruby#251 (@zheng-yongping)
  * Remove top-level `In` and `Out` constants
    SciRuby/iruby#229 (@kojix2)
  * Use text/plain for the default format of `Numo::NArray` objects
    SciRuby/iruby#255 (@kojix2)
  * Use ffi-rzmq as the default ZeroMQ adapter
    SciRuby/iruby#256 (@kojix2)
  * Drop rbczmq support SciRuby/iruby#260
    (@rstammer)
  * Add ruby-vips image support SciRuby/iruby#279
    (@ankane)
  * Replace mimemagic with mime-types
    SciRuby/iruby#291 (@mrkn)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants