Skip to content

Fixes Extended grammar optimization mode would crash if TopK sampling is set to zero. #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2025
Merged

Fixes Extended grammar optimization mode would crash if TopK sampling is set to zero. #1282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion LLama/Sampling/DefaultSamplingPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,8 @@ public override LLamaToken Sample(SafeLLamaContextHandle ctx, int index)
}

// Extended optimization : Apply the grammar to the TopK tokens and check if the selected token is valid
if (GrammarOptimization == GrammarOptimizationMode.Extended)
// Only run if TopK > 0
if (GrammarOptimization == GrammarOptimizationMode.Extended && TopK > 0)
{
// Calculate a safe TopK value
var safeTopK = Math.Min(TopK, nativeAll.Data.Length);
Expand Down
Loading