Unit tests for MeshIndexSet. - #7219
Merged
stephenworsley merged 16 commits intoJul 27, 2026
Merged
Conversation
trexfeathers
commented
Jul 23, 2026
Contributor
Author
trexfeathers
commented
Jul 23, 2026
Contributor
Author
There was a problem hiding this comment.
- Should have a more thorough parameterisation of the three locations
- Should test whether the original
MeshXYis all lazy connectivities/coords versus all NumPy versions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## FEATURE_index_set #7219 +/- ##
=====================================================
+ Coverage 89.86% 90.42% +0.56%
=====================================================
Files 92 93 +1
Lines 25573 25818 +245
Branches 4768 4795 +27
=====================================================
+ Hits 22980 23346 +366
+ Misses 1789 1693 -96
+ Partials 804 779 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
stephenworsley
requested changes
Jul 24, 2026
stephenworsley
requested changes
Jul 24, 2026
stephenworsley
requested changes
Jul 27, 2026
stephenworsley
requested changes
Jul 27, 2026
stephenworsley
approved these changes
Jul 27, 2026
stephenworsley
left a comment
Contributor
There was a problem hiding this comment.
Looks good. My remaining concerns about test coverage (see here) would be better addressed in the integration tests.
trexfeathers
marked this pull request as ready for review
July 27, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.