Support utf8 by default for saving strings. - #7230
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7230 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 92 92
Lines 25335 25336 +1
Branches 4731 4731
=======================================
+ Hits 22889 22890 +1
Misses 1675 1675
Partials 771 771 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ukmo-ccbunney
approved these changes
Jul 29, 2026
ukmo-ccbunney
left a comment
ukmo-ccbunney
left a comment
Contributor
There was a problem hiding this comment.
Looks good. 👍🏼
I've run some test on the command line and everything is behaving as expected.
It's nice to not have to specify an encoding for saving and have it "just work" by default. 👏🏼
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7195
See all the arguments there.
Ideally this would go direct into Iris 3.16, but I fear we just ran out of time.
If not in 3.16 we will need to revise this, make controllable (?via FUTURE?) for a backwards-incompatible change.
WIP: first let's see if any tests fail...