Compatibility with python-xxhash v4.0 - #7262
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.16.x #7262 +/- ##
========================================
Coverage 90.42% 90.42%
========================================
Files 93 93
Lines 25812 25814 +2
Branches 4795 4796 +1
========================================
+ Hits 23340 23342 +2
Misses 1693 1693
Partials 779 779 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pp-mo
requested changes
Sep 1, 2026
pp-mo
left a comment
Member
There was a problem hiding this comment.
LGTM
I was going to say we should definitely use a utf8 encoding,
but I now see that is the default anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #7251. This will not show up in our CI (conda-based) until conda-forge/python-xxhash-feedstock#46 is merged. But I have tested locally.
Targeting
v3.16.xsince this is planned to be issued as part of a patch release.Checklist
Important
The Iris core developers are here to help! If anything below is unclear, just post a comment asking for help 😊
(further reading)
Tip
Things you can trigger on this PR:
9999for this PR's number - to re-trigger the CLA check:https://cla-assistant.io/check/SciTools/iris?pullRequest=9999