cangjie(-lts): Add version 1.1.3 and 1.0.5 - #8290
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Summary by CodeRabbit
WalkthroughChangesCangjie SDK channel manifests
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
This comment was marked as outdated.
This comment was marked as outdated.
|
/verify |
This comment was marked as outdated.
This comment was marked as outdated.
|
/verify |
|
All changes look good. Wait for review from human collaborators. cangjie-lts
cangjie
|
z-Fng
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
|
We commonly have LTS versions in the main bucket, especially if both of them are equally important 🤔 (example: |
|
This is not a standardized convention, and it is certainly a subject of debate. I'm on the side that believes all variants should be submitted to the |
I got into a heated argument when trying to follow this before 😅 |
Apologies, I missed this comment. I'm a bit lost on how we used to handle LTS. I actually notice more LTS packages sitting in the main bucket, while versions and extras seem to have fewer of them. There are even commits that moved LTS packages out of the versions bucket, e.g. |
Importance isn't a metric here, and the main bucket and versions bucket are actually of equal importance: The only difference is requirement of a manual clone of the bucket if it hasn't been already. (While this reminds me of an unfinished concept of mine: automatically cloning the |
https://cangjie-lang.cn/en
<manifest-name[@version]|chore>: <general summary of the pull request>