Skip to content

cangjie(-lts): Add version 1.1.3 and 1.0.5 - #8290

Merged
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
sitiom:cangjie
Jul 12, 2026
Merged

cangjie(-lts): Add version 1.1.3 and 1.0.5#8290
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
sitiom:cangjie

Conversation

@sitiom

@sitiom sitiom commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

https://cangjie-lang.cn/en

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 225f5828-c5dd-4084-b7bc-711d9bfe084e

📥 Commits

Reviewing files that changed from the base of the PR and between ec0fc30 and 1879d64.

📒 Files selected for processing (2)
  • bucket/cangjie-lts.json
  • bucket/cangjie.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • bucket/cangjie.json
  • bucket/cangjie-lts.json

Summary by CodeRabbit

  • New Features
    • Added installation support for the Cangjie SDK on 64-bit Windows.
    • Added package manifests for both Cangjie stable (v1.1.3) and Cangjie LTS (v1.0.5).
    • Configured per-user environment setup, including CANGJIE_HOME and required PATH updates for the cjpm\bin directory.
    • Added version checking and autoupdate automation to keep download URLs and SHA-256 hashes aligned with new releases.

Walkthrough

Changes

Cangjie SDK channel manifests

Layer / File(s) Summary
Cangjie SDK channel manifests
bucket/cangjie-lts.json, bucket/cangjie.json
Adds Windows x64 Cangjie LTS and STS manifests with download hashes, install/uninstall scripts, PATH and CANGJIE_HOME configuration, version detection, and autoupdate rules.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title names the Cangjie manifests and added versions, matching the main change.
Description check ✅ Passed The description includes the homepage, linked issue, and required checklist items from the template.
Linked Issues check ✅ Passed The added Cangjie SDK manifests satisfy the issue's non-GUI, English-doc, full-version, and versioned-download requirements.
Out of Scope Changes check ✅ Passed The changes stay focused on adding the Cangjie STS and LTS manifests, with only related installer and update script updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sitiom sitiom mentioned this pull request Jul 12, 2026
2 tasks
@sitiom

sitiom commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

This comment was marked as outdated.

@sitiom

sitiom commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

This comment was marked as outdated.

z-Fng
z-Fng approved these changes Jul 12, 2026
@z-Fng

z-Fng commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

cangjie-lts

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

cangjie

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@z-Fng
z-Fng merged commit 3f4df69 into ScoopInstaller:master Jul 12, 2026
2 checks passed
@chawyehsu

Copy link
Copy Markdown
Member

Comment thread bucket/cangjie-lts.json
@sitiom

sitiom commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

ScoopInstaller/Extras#17662 (comment) ...

We commonly have LTS versions in the main bucket, especially if both of them are equally important 🤔 (example: nodejs and nodejs-lts)

@sitiom
sitiom deleted the cangjie branch July 12, 2026 10:31
@chawyehsu

Copy link
Copy Markdown
Member

This is not a standardized convention, and it is certainly a subject of debate. I'm on the side that believes all variants should be submitted to the Versions bucket. nodejs-lts is merely one historical example; I could just as easily cite dotnet-sdk-lts as a counter-example.

@sitiom

sitiom commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

This is not a standardized convention, and it is certainly a subject of debate. I'm on the side that believes all variants should be submitted to the Versions bucket. nodejs-lts is merely one historical example; I could just as easily cite dotnet-sdk-lts as a counter-example.

I got into a heated argument when trying to follow this before 😅

@z-Fng

z-Fng commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

ScoopInstaller/Extras#17662 (comment) ...
Please submit variants to the Versions bucket and submit only the main one here

Apologies, I missed this comment. I'm a bit lost on how we used to handle LTS. I actually notice more LTS packages sitting in the main bucket, while versions and extras seem to have fewer of them. There are even commits that moved LTS packages out of the versions bucket, e.g. windowsdesktop-runtime-lts ScoopInstaller/Extras@7492e8c. That's why I went ahead and merged it. Could we open a discussion on this, or perhaps document our existing guidelines regarding it?

@chawyehsu

Copy link
Copy Markdown
Member

equally important

Importance isn't a metric here, and the main bucket and versions bucket are actually of equal importance: scoop search even considers all official buckets.

The only difference is requirement of a manual clone of the bucket if it hasn't been already. (While this reminds me of an unfinished concept of mine: automatically cloning the versions bucket when running scoop install versions/nodejs-lts, similar to how Homebrew Taps work.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: cangjie-sdk

3 participants