7zip-zstd: Update to version v26.01-1.5.7-r1, fix checkver & autoupdate - #2926
Conversation
|
/verify |
|
All changes look good. Wait for review from human collaborators. 7zip-zstd
|
WalkthroughThe Changes7zip-zstd Manifest Update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
bucket/7zip-zstd.json (2)
6-6:⚠️ Potential issue | 🟡 MinorUse SPDX operators instead of comma separator for compound licenses.
The SPDX specification requires
ANDorORoperators for compound licenses, not commas. Based on the upstream COPYING file, both licenses apply to different parts of the codebase (LGPL-2.1-or-later for most code, BSD-3-Clause for LZFSE decompression), so the identifier should be:"identifier": "BSD-3-Clause AND LGPL-2.1-or-later"not
"BSD-3-Clause, LGPL-2.1-or-later".
46-51:⚠️ Potential issue | 🟡 MinorThe checkver pattern works correctly on real assets but uses unnecessarily loose suffix matching.
The JSONPath filter correctly identifies 7z assets (excluding ndm variants), and the regex successfully extracts version components from real release URLs. However, the pattern ending
(?:arm|x)is overly permissive—it matches only the first character of architecture suffixes (e.g., capturing-xfrom-x64.exe), leading to inconsistent prefix group values across architectures. Since thereplacestatement uses only${sevenzip},${zstd}, and${release}(ignoring the prefix group), this causes no functional issues but indicates unnecessarily loose regex design.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 898f5f19-b488-4b06-a3eb-b022041410ca
📒 Files selected for processing (1)
bucket/7zip-zstd.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. 7zip-zstd
|
z-Fng
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Summary
Updates
7zip-zstdto version 26.01-1.5.7-r1, rewrites the description, updates project URLs, adds shortcuts, and heavily modernizes thecheckver/autoupdateparsing logic to maintain future compatibility.Changes
descriptionwith full details of supported modern compression codecs.homepageto the official project domain (https://mcmilk.de/...).licensefield to dual-license (BSD-3-Clause, LGPL-2.1-or-later) with full SPDX alignment and explicitHEADfile URL.installerscript utilizingExpand-7zipArchiveto clean up temporary uninstaller and installation structures.binlist order and append7za.exe.7-zip.chm) and refine the File Manager shortcut path to prevent main-menu pollution.checkverto parse/releases/latestusing a robust JSONPath filtering mechanism and custom regex named capture groups (matchTag,matchSevenzip,matchZstd,matchRelease,matchPrefix) to streamline the version format matching.autoupdateURLs to adaptively consume the new regex tokens.Notes
x32tox86in recent releases.7-Zip-Zstandardstart menu folder.Testing
The test results are as follows:
<manifest-name[@version]|chore>: <general summary of the pull request>