Skip to content

Add rock paper scissors module#104

Merged
SCDerox merged 22 commits intoScootKit:mainfrom
DEVTomatoCake:main
Feb 19, 2023
Merged

Add rock paper scissors module#104
SCDerox merged 22 commits intoScootKit:mainfrom
DEVTomatoCake:main

Conversation

@DEVTomatoCake
Copy link
Copy Markdown
Contributor

Adds the suggestion from https://features.sc-network.net/board/custombot/240
Translations are prepared, they just have to be added in Weblate.

This PR also updates the node-schedule package (no real changes, only security fix) and eslint, because why not.
It also fixes a few small typos in the README and increases the time for paginated buttons menus from 20s to 40s. Still too low but may prevent users spamming the buttons to get to a page in time.
If any of those changes above are somehow unwanted, feel free to revert them.

@SCDerox
Copy link
Copy Markdown
Member

SCDerox commented Feb 17, 2023

Thanks so much for your contribution!
Please add localization directly in the locales directory - it will get synced to our weblate once we roll-out your changes on SCNX. We do not add strings directly to weblate.

Once ready, please request a review from me.

Please note that rollout on SCNX depends on our sole discretion and it may take up to two weeks to reach our main branch - beta branches usually receive your changes after merge).

Because this is your first PR: If you want to receive a small bounty (= small amount of money) after we've merged your PR as part of our Developer Programm, please create an SCNX Marketplace Organization, enable payouts and make sure your Discord-Account is linked to your GitHub.

@DEVTomatoCake
Copy link
Copy Markdown
Contributor Author

Well, as I can't request a review, take this comment as request for it.

Also not sure how to get the numeral id of the org, doesn't look like it's the name.

@SCDerox
Copy link
Copy Markdown
Member

SCDerox commented Feb 17, 2023

You should be able to request a review in GitHub 🤔

Anyway, to get the ID of your org, please visit https://scnx.app/api/marketplace/organizations/\<yourslughere>

@DEVTomatoCake
Copy link
Copy Markdown
Contributor Author

DEVTomatoCake commented Feb 17, 2023

You should be able to request a review in GitHub 🤔

I thought so too, but where?

Copy link
Copy Markdown
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution - love the module.
I found some small (mostly style) issues. Please find them in the review comments. After fixing them, please request a re-review and we'll be ready to merge your PR.

Additionally, certain patterns in rock-paper-scissor.js seem to repeat multiple times (such as win calculation for users/bots). This is not something we require contributors to fix, so this is only a suggestion on how you could improve maintainability of your code in the future.

Comment thread locales/de.json Outdated
Comment thread modules/rock-paper-scissors/module.json Outdated
Comment thread modules/rock-paper-scissors/commands/rock-paper-scissors.js Outdated
Copy link
Copy Markdown
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, your module will be available on SCNX shortly.

@SCDerox SCDerox merged commit cf3af4e into ScootKit:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants