Skip to content

Uno fixes#119

Merged
SCDerox merged 4 commits intoScootKit:mainfrom
DEVTomatoCake:uno-fixes
Jul 7, 2023
Merged

Uno fixes#119
SCDerox merged 4 commits intoScootKit:mainfrom
DEVTomatoCake:uno-fixes

Conversation

@DEVTomatoCake
Copy link
Copy Markdown
Contributor

@DEVTomatoCake DEVTomatoCake commented Jul 2, 2023 •
edited
Loading

  • Fixes Uno game bugs which could be achieved by using multiple card decks and not updating them
  • Updates discord.js to v13.16.0 (latest v13) from v13.12.0
  • Updates package-lock.json automatically
  • Replaces parts of Connect Four emoji string versions with their unicode version as you're not supposed to use them as strings
  • Increases auto Uno start time from 90 seconds to 180 seconds
  • Increases recent card history from 2 to 3
  • Kicks inactive players from the game (warning after one minute, kick after two minutes)

@DEVTomatoCake
Uno fixes
6396eed 
Fixes some Uno game bugs using multiple card decks, as well as updating package files
@DEVTomatoCake
Add inactive timeouts + some bug fixes
ecb4d91
@DEVTomatoCake DEVTomatoCake marked this pull request as ready for review July 2, 2023 20:08
@SCDerox SCDerox self-requested a review July 6, 2023 07:09
SCDerox
SCDerox previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one small thing noticed - all other changes will be availbile in the beta branch shortly. To get this merged into the repo, please fix the small typo I found ^^

Comment thread modules/rock-paper-scissors/module.json Outdated
@DEVTomatoCake @SCDerox
Update modules/rock-paper-scissors/module.json
48ebc4d 
Co-authored-by: Simon <simon.csaba@gmx.de>
SCDerox
SCDerox approved these changes Jul 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the quick fix. Your PR will be merged shortly.
We greatly appropriate your continued contributions ❤️

@SCDerox SCDerox merged commit 0ce193d into ScootKit:main Jul 7, 2023
@DEVTomatoCake DEVTomatoCake deleted the uno-fixes branch July 8, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SCDerox SCDerox SCDerox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DEVTomatoCake @SCDerox