Skip to content

Added security measure for the massrole command#121

Merged
SCDerox merged 8 commits intoScootKit:mainfrom
hfgd123:main
Aug 30, 2023
Merged

Added security measure for the massrole command#121
SCDerox merged 8 commits intoScootKit:mainfrom
hfgd123:main

Conversation

@hfgd123
Copy link
Copy Markdown
Contributor

@hfgd123 hfgd123 commented Aug 11, 2023

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 29, 2023

CLA assistant check
All committers have signed the CLA.

@SCDerox
Copy link
Copy Markdown
Member

SCDerox commented Aug 29, 2023

Hi, sorry for the delay, I was on vacation. Please update your branch to the latest base branch version - please also sign the CLA to continue. After that, I'll be able to review your PR and will merge it asap.

Copy link
Copy Markdown
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged - small locales issue.

Without the request changes, your error message would not display the emoji correctly:
image

Comment thread locales/de.json Outdated
Comment thread locales/en.json Outdated
hfgd123 and others added 2 commits August 30, 2023 20:06
Co-authored-by: Simon <simon.csaba@gmx.de>
Co-authored-by: Simon <simon.csaba@gmx.de>
@hfgd123 hfgd123 requested a review from SCDerox August 30, 2023 18:06
Copy link
Copy Markdown
Member

@SCDerox SCDerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing these few issues - your changes will be available on SCNX shortly.
Thanks so much for your continued contributions ❤️

@SCDerox SCDerox merged commit 6b42fd9 into ScootKit:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants