Conversation
|
The Discord RPC tool looks useful — happy to merge that part. However this PR also deletes most of docs/wrtc.md (the anti-scam checklist, detailed tables, troubleshooting). Please resubmit with only the RPC tool files (tools/discord_rpc.py, tools/rustchain_rpc.py, README.md changes) and leave wrtc.md untouched. |
Scottcjn
left a comment
There was a problem hiding this comment.
Review: Request Changes — Discord RPC idea is good, but PR deletes critical docs
The good
The Discord Rich Presence concept is cool — showing mining status in Discord is a nice community feature.
The bad
This PR deletes 401 lines from docs/wrtc.md — our comprehensive wRTC quickstart guide including:
- Anti-scam checklist with verification steps
- Step-by-step Raydium swap guide
- Bridge instructions (both directions)
- Troubleshooting section
- Emergency contacts
That guide protects users from scams. Deleting it is a dealbreaker.
Other issues
- Two duplicate files:
discord_rpc.pyandrustchain_rpc.pydo the same thing — pick one - Placeholder Client ID
123456789012345678— won't work without registering a Discord Developer App - Wrong API field: Uses
stats['balance']but our endpoint returnsamount_rtc - README change adds duplicate line: "Onboarding Tutorial" row appears twice
To fix
- Revert all changes to
docs/wrtc.md— do not touch that file - Revert README.md changes (the duplicate line)
- Keep only ONE Discord RPC script
- Fix the API response field to
amount_rtc - Add a note about registering a Discord Developer App for the Client ID
Resubmit with just the Discord RPC tool and I'll review for merge.
Review: CLOSEDiscord RPC ToolThe two Python scripts ( Problem: docs/wrtc.md DestructionThis PR deletes 401 lines from
That document was carefully written to protect new users from scams. Removing it is unacceptable. RecommendationIf you'd like to contribute the Discord RPC tool, please resubmit as a new PR that only adds Closing this PR. |
|
Closing — the Discord RPC scripts are welcome but the wRTC doc deletion is not acceptable. Please resubmit with only the tool additions. |
- Complete translation of RustChain README to Simplified Chinese - Natural, fluent translation (not just machine translation) - Preserved all formatting, links, and code blocks - Technical terms properly translated with English where appropriate Translation includes: - Project introduction and features - Quick start guide - Installation instructions - API documentation - Hardware antiquity multipliers - Security model - Related projects and links Ready for review!
- 翻译主要部分为简体中文 - 保持技术准确性 - 保留所有代码示例和链接 - 格式与原文一致 Task Scottcjn#176 - Translate RustChain README to Any Language (5 RTC) 翻译者: Green Dragon One 🦞
* Add Chinese translation (README_ZH.md) for Issue #176 - Complete translation of RustChain README to Simplified Chinese - Natural, fluent translation (not just machine translation) - Preserved all formatting, links, and code blocks - Technical terms properly translated with English where appropriate Translation includes: - Project introduction and features - Quick start guide - Installation instructions - API documentation - Hardware antiquity multipliers - Security model - Related projects and links Ready for review! * Add wRTC Price Ticker Bot for Telegram (Issue #162) - Complete Telegram bot for wRTC price tracking - Fetch prices from multiple APIs (DexScreener, Jupiter) - Support /price command - Display price in USD and SOL - Show 24h price change percentage - Show liquidity information - Direct links to Raydium swap and DexScreener - Price change detection (>10% in 1 hour) for alerts - Multiple API sources with automatic fallback - Comprehensive README with setup instructions - Test script for price fetching verification Features: - Real-time wRTC price from Raydium DEX - Price in USD and SOL - 24-hour price change percentage - Liquidity information - Price alert detection - API fallback mechanism Implementation: - PriceFetcher class for API integration - TelegramBot class for Telegram API - Formatted messages with emojis and links - Error handling and API fallback Token Details: - Mint: 12TAdKXxcGf6oCv4rqDz2NkgxjyHq6HQKoxKZYGf5i4X - Supply: 8,300,000 wRTC - Raydium Pool: 8CF2Q8nSCxRacDShbtF86XTSrYjueBMKmfdR3MLdnYzb Payout: - Working bot with /price command ✅ (12 RTC) - Auto-posting + price alerts + clean formatting ✅ (8 RTC) Total Expected: 20 RTC Closes #162 --------- Co-authored-by: zhanglinqian <zhanglinqian@example.com>
* Add Chinese translation (README_ZH.md) for Issue #176 - Complete translation of RustChain README to Simplified Chinese - Natural, fluent translation (not just machine translation) - Preserved all formatting, links, and code blocks - Technical terms properly translated with English where appropriate Translation includes: - Project introduction and features - Quick start guide - Installation instructions - API documentation - Hardware antiquity multipliers - Security model - Related projects and links Ready for review! * Add wRTC Holder Snapshot Tool (Issue #164) - Add Python CLI tool to query Solana blockchain for wRTC holders - Support for multiple public RPC endpoints - Automatic wallet labeling (Reserve, Raydium LP, Team) - Calculate concentration metrics (Gini coefficient, whale detection) - Format output with balances and % of supply - Add comprehensive README with usage examples - Add test version with mock data for testing - Bonus: Add interactive web UI with real-time data display Features: - Lists all wRTC token holders with balances - Shows percentage of total supply for each holder - Labels known wallets (reserve, LP pool, team) - Calculates Gini coefficient for concentration analysis - Identifies whale wallets (>1% of supply) - Web UI with responsive design - Auto-refresh capability Closes #164 --------- Co-authored-by: zhanglinqian <zhanglinqian@example.com>
Translation of README.md to Simplified Chinese for Chinese-speaking community. Bounty: Issue Scottcjn#176 (5 RTC) Key sections translated: - Project overview and core concept (Proof-of-Antiquity) - Quick start guide and installation instructions - Hardware multipliers and supported platforms - Network architecture and API endpoints - Security model and anti-VM detection - Related projects and attribution All technical terms, links, code blocks, and formatting preserved. Native Chinese speaker translation - natural and accurate.
Translation of README.md to Simplified Chinese for Chinese-speaking community. Bounty: Issue #176 (5 RTC) Key sections translated: - Project overview and core concept (Proof-of-Antiquity) - Quick start guide and installation instructions - Hardware multipliers and supported platforms - Network architecture and API endpoints - Security model and anti-VM detection - Related projects and attribution All technical terms, links, code blocks, and formatting preserved. Native Chinese speaker translation - natural and accurate.
No description provided.