fix(security): enforce Ed25519 verification and hide escrow_secret (#8179) - #8183
Open
shiyaam-s07 wants to merge 3 commits into
Open
fix(security): enforce Ed25519 verification and hide escrow_secret (#8179)#8183shiyaam-s07 wants to merge 3 commits into
shiyaam-s07 wants to merge 3 commits into
Conversation
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
Author
|
Submitted fix in PR #8183 with Ed25519 signature verification and payload redaction for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8179
🛡️ Security Vulnerability & Fix Overview
This PR resolves a high-severity security issue where GPU escrow creation endpoints (
/render/escrow) accepted arbitraryfrom_walletaddress inputs without validating ownership, while also leaking internalescrow_secretdata back in the API payload.Ed25519 Wallet Ownership Verification:
signatureandmessage(nonce/timestamp) parameters from incoming payload requests innode/gpu_render_protocol.py.cryptographylibrary (ed25519.Ed25519PublicKey) to guarantee that the caller strictly controls the correspondingfrom_walletpublic key.401 Unauthorizedresponse if signatures are missing, malformed, or mathematically mismatched.Data Leakage Redaction:
escrow_secretfrom the returned endpoint dictionary payload insidecreate_escrow, preventing unauthorized exposure of sensitive state secrets in API responses.🧪 Automated Testing & Verification
tests/test_gpu_render_protocol.py):401.401.escrow_secretis completely absent from API response outputs.node/airdrop_v2.pyto achieve a 100% test pass rate across the workspace viapytest.📋 Checklist