fix: 🐛 read SCRAPEGRAPHAI_TELEMETRY_ENABLED from the environment, not the config file

[HKlabworks]

Thanks for the library. While reviewing the telemetry code before adopting it, I found that the documented opt-out does not take effect on its own.

The bug

_check_config_and_environ_for_telemetry_flag checks that the environment variable exists, then reads its value out of the config file:

if os.environ.get("SCRAPEGRAPHAI_TELEMETRY_ENABLED") is not None:
    try:
        telemetry_enabled = config_obj.getboolean("DEFAULT", "telemetry_enabled")
    except Exception:
        pass

If ~/.scrapegraphai.conf has no telemetry_enabled key, which is the state after a fresh install, getboolean raises, the bare except swallows it, and telemetry_enabled keeps its default of True.

So SCRAPEGRAPHAI_TELEMETRY_ENABLED=false, which is what the README recommends, leaves telemetry enabled unless the user has also written a config file. The failure is silent: nothing logs, and the flag reads as if the setting were honoured.

Reproduced on 2.2.2 with the variable set to false and no config key:

before: True
after:  False

The fix

Parse the variable's own value, reusing configparser.ConfigParser.BOOLEAN_STATES so the environment variable and the config file accept the same spellings (true/false, yes/no, on/off, 1/0). That keeps the two paths consistent rather than inventing a second set of rules.

An unrecognised value now logs a warning and leaves the flag unchanged, instead of being swallowed.

Precedence is unchanged in spirit and now actually works: config file first, environment variable overrides it.

Tests

Adds tests/test_telemetry_flag.py, 20 cases covering the config path, the environment path, precedence between them, accepted boolean spellings, and an unparseable value. The key one is test_env_var_disables_with_no_config_key, which is the regression.

20 passed

Note on scope

This only changes how the flag is read. It does not change the default, the payload, or the endpoint. Happy to adjust the approach if you would rather handle it differently.