Skip to content

Add schema validation workflow#278

Merged
WorldLanguages merged 2 commits intoScratchAddons:masterfrom
Hans5958:schema-validation-1
Sep 14, 2020
Merged

Add schema validation workflow#278
WorldLanguages merged 2 commits intoScratchAddons:masterfrom
Hans5958:schema-validation-1

Conversation

@Hans5958
Copy link
Copy Markdown
Member

This PR adds a schema validation workflow for addon manifests, based on the schema that I made on Hans5958/ScratchAddons-Schema, with some actions that I have modified so it works properly.

The workflow have been tested rigorously by myself and it seems that it is working properly.

This pull request partially resolves #229 as there will be future PRs for updating all addon manifest for the schema, which will be done after this PR.

Some notes:

  • There is still a need to get the descriptions done on the schema. I have filled some of the description based on the wiki, but there still some field missing, indicated by the TODO comments.
  • Tell me if you need to move the repositories from mine to this organization.
  • I made this so it only works on the master branch of this repo only. Should I make it work on all forks and branches also? It's quite easy, don't worry.

@WorldLanguages WorldLanguages merged commit b4edeae into ScratchAddons:master Sep 14, 2020
@Hans5958
Copy link
Copy Markdown
Member Author

@WorldLanguages please answer questions

@Hans5958 Hans5958 deleted the schema-validation-1 branch October 3, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create JSON schema for the addon metadata/manifest

2 participants