Fix #309: import to CDN does not work in Firefox#310
Merged
WorldLanguages merged 1 commit intoScratchAddons:masterfrom Sep 19, 2020
Merged
Fix #309: import to CDN does not work in Firefox#310WorldLanguages merged 1 commit intoScratchAddons:masterfrom
WorldLanguages merged 1 commit intoScratchAddons:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox has a bug where
importandimport()do not work from moz-extension:// URLs, if importing from a https URL.To fix this, I added
addon.tab.loadScript(urlString)and changed addons to use that, instead of imports.I also moved a library to the folder of the addon using it.