Skip to content

Add pre-send check and warning#247

Merged
Hans5958 merged 6 commits intomasterfrom
pre-send-check
Feb 2, 2023
Merged

Add pre-send check and warning#247
Hans5958 merged 6 commits intomasterfrom
pre-send-check

Conversation

@Hans5958
Copy link
Copy Markdown
Member

@Hans5958 Hans5958 commented Aug 26, 2022

As it says, it adds a pre-send check and warning, which checks the message before sending and puts a warning if one or more keywords are detected on the feedback content.

The current form is quite preliminary, and may be improved on this PR based on necessity. Everyone that had access is welcome to edit it.

@Hans5958
Copy link
Copy Markdown
Member Author

The two examples that is currently implemented.

image

image

@Hans5958 Hans5958 added scope: content Related to the contents of the website, excluding blog and docs type: annoucement type: enhancement New feature or request and removed type: annoucement labels Aug 26, 2022
@CST1229
Copy link
Copy Markdown
Member

CST1229 commented Aug 26, 2022

I think the warning should also direct users to the places where they can actually suggest or report to the ST.

Comment thread static/assets/js/feedback.js Outdated
@Hans5958
Copy link
Copy Markdown
Member Author

I think the warning should also direct users to the places where they can actually suggest or report to the ST.

@CST1229 This is the one I thinking to add, but I'm confused about directing to where specifically. Could you suggest what phrashes to add on that sentence?

@Hans5958 Hans5958 added the help wanted Extra attention is needed label Aug 31, 2022
Comment thread static/assets/js/feedback.js Outdated
@Hans5958 Hans5958 force-pushed the pre-send-check branch 2 times, most recently from 3e08605 to eede01a Compare January 22, 2023 17:06
@Hans5958
Copy link
Copy Markdown
Member Author

Alright, folks. I will expedite this PR to be merged. Expect this to be merged in few days or so. You may still give comments about it.

The warnings can be expanded in the future, if we want to handle more cases in the future.

As of the "reporting to where" side of things, I haven't got an idea. What I'm considering is that there are multiple ways to report something. Do we direct it to report on the project/user page? Or on the "contact us" page? Or send them an e-mail? Or a forum post? Any other ideas?

@mxmou
Copy link
Copy Markdown
Member

mxmou commented Jan 23, 2023

As of the "reporting to where" side of things, I haven't got an idea. What I'm considering is that there are multiple ways to report something. Do we direct it to report on the project/user page? Or on the "contact us" page? Or send them an e-mail? Or a forum post? Any other ideas?

I think it makes sense to link to Contact Us - it has links to the forums and an option to contact the ST directly. The message could also mention the ability to report content on the Scratch website, possibly linking to the wiki.

@Hans5958
Copy link
Copy Markdown
Member Author

Ah, I forgot there is the wiki. It explained quite well about the different methods. I think that's the best way, which is to just link it.

@Hans5958 Hans5958 merged commit bef541e into master Feb 2, 2023
WorldLanguages added a commit that referenced this pull request Feb 2, 2023
WorldLanguages added a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed scope: content Related to the contents of the website, excluding blog and docs type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants