Skip to content

Adopt @screenly-labs/signage-kit for degraded mode - #5

Merged
vpetersson merged 2 commits into
masterfrom
adopt-signage-kit
Jul 13, 2026
Merged

Adopt @screenly-labs/signage-kit for degraded mode#5
vpetersson merged 2 commits into
masterfrom
adopt-signage-kit

Conversation

@vpetersson

Copy link
Copy Markdown
Contributor

Part of the fleet-wide adoption of @screenly-labs/signage-kit: this app now consumes the shared degraded-mode pipeline (support floor, CSS down-level recipe, JS bundler, inline gate, replaceChildren polyfill, and the html.legacy kill-switch) instead of its own inlined copies.

Purely mechanical — behaviour is unchanged. Build output verified equivalent:

  • @layer in built CSS: 0
  • html.legacy kill-switch present: yes (3)
  • :lang( in built CSS: 0
  • gate injected into dist/index.html: yes (classList x2)
  • es-check es2017 dist/static/js/main.js: passes
  • JS format: IIFE (index.html loads a classic <script defer>)

typecheck, lint, and test all pass.

🤖 Generated with Claude Code

Replace the inlined degraded-mode plumbing (support floor, CSS down-level recipe,
JS bundler, inline gate, replaceChildren shim, html.legacy kill-switch) with the
shared package (github:Screenly-Labs/signage-kit#2026.7.0). Build output verified
equivalent: 0 @layer, kill-switch present, 0 :lang(), gate injected, es2017.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the app’s “degraded mode” implementation (support floor, inline gate, CSS down-leveling recipe, JS bundling, and polyfills) from app-local copies to the shared @screenly-labs/signage-kit pipeline, aligning this repo with the fleet-wide rollout while keeping the shipped output equivalent.

Changes:

  • Add @screenly-labs/signage-kit and switch the build pipeline to injectGate, processCss, and bundleJs.
  • Replace the inline degraded-mode gate in index.html with build-time injection.
  • Use the kit’s shared CSS preset + polyfills, removing the app-local polyfills shim and legacy CSS kill-switch block.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Adds @screenly-labs/signage-kit and removes the in-repo browserslist config block.
bun.lock Locks @screenly-labs/signage-kit GitHub dependency resolution.
build.js Replaces inlined CSS/JS build logic and gate injection with signage-kit helpers.
index.html Removes the inline degraded-mode gate script in favor of build-time injection.
assets/static/styles/tailwind.css Imports the kit preset and removes app-local degraded-mode kill-switch CSS.
assets/static/js/main.ts Switches to the kit-provided polyfills side-effect import.
assets/static/js/polyfills.ts Deletes the app-local replaceChildren shim (now provided by the kit).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build.js Outdated
Comment thread build.js Outdated
Comment thread package.json
@vpetersson
vpetersson merged commit 8ceaf89 into master Jul 13, 2026
1 check passed
@vpetersson
vpetersson deleted the adopt-signage-kit branch July 13, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants