fix(viewer): pre-parse media to reduce VLC playback startup gap#2736
Merged
nicomiguelino merged 2 commits intoScreenly:masterfrom Apr 14, 2026
Merged
Conversation
- Call `get_media().parse()` in `VLCMediaPlayer.set_asset()` to pre-load file metadata before `play()` is called
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce the visible blank gap when transitioning into VLC-played videos (notably on Raspberry Pi 1–4) by pre-parsing VLC media metadata during VLCMediaPlayer.set_asset() before play() is invoked.
Changes:
- Pre-parse the current VLC media (
get_media().parse()) immediately afterset_mrl()and audio device selection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add `TestVLCMediaPlayer` class with shared patch setup in `setUp`/`tearDown` - Assert that `get_media().parse()` is called on `set_asset()`
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issues Fixed
Description
Calls
get_media().parse()inVLCMediaPlayer.set_asset()to pre-load file metadata beforeplay()is invoked. This gives VLC a head start on opening the file and reading codec info, reducing the startup delay that causes the visible blank screen between slides.Checklist