fix(install): don't stop getty@tty1 during a local-console install - #3241
Merged
vpetersson merged 1 commit intoAug 4, 2026
Merged
Conversation
A local-console install runs on tty1 itself (ansible_connection=local). The 'Disable getty on tty1' step used state: stopped, which tears down the very session the installer is running in: the screen goes blank mid-install, and with the login prompt now gone and SSH not enabled the user is locked out with no way back in. Installs run over SSH never hit this, which is why it only bites direct-on-screen installs. Drop state: stopped from the getty@tty1 and autologin@tty1 tasks and keep enabled: false. The install ends in a reboot, after which the disabled units do not start, so the display still comes up with no login prompt. Reported at forums.screenly.io/t/install-leading-to-blank-screen/6754. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJ3ucEkn62cbgPoisAZ5LQ
|
vpetersson
approved these changes
Aug 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3241 +/- ##
=========================================
Coverage ? 90.82%
=========================================
Files ? 76
Lines ? 8361
Branches ? 885
=========================================
Hits ? 7594
Misses ? 549
Partials ? 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported an install that went to a blank screen and locked them out. They traced the hang to the ansible task named
Disable getty on tty1, which is what pinned this down.Root cause
A local-console install runs on
tty1itself (ansible_connection=local). The tty1 login-prompt tasks inansible/roles/system/tasks/boot.ymlused:state: stoppedongetty@tty1.service(or raspi-config'sautologin@tty1.service) tears down the session the installer is running in. Mid-install the screen goes blank, and because the login prompt has just been removed and SSH was never enabled, the user is locked out with no way back in. Installs run over SSH never hit this — the installer is not living on tty1 — which is exactly why the reporter only saw it on a direct-on-screen install.Fix
Drop
state: stoppedfrom both thegetty@tty1andautologin@tty1tasks and keepenabled: false. The two requirements are still both met:bin/install.sh), after which the now-disabledunits do not start, so the signage display comes up with no login prompt.A regression-guarding comment is added above the tasks so
state: stoppedis not reintroduced.Testing
getty@tty1.serviceends updisabledafter this task runs, so no login prompt appears on the display on the next boot.state: stoppedon the unit hosting the activeconnection=localsession; the SSH-vs-console asymmetry the reporter observed matches exactly.Reported at https://forums.screenly.io/t/install-leading-to-blank-screen/6754
🤖 Generated with Claude Code
https://claude.ai/code/session_01HJ3ucEkn62cbgPoisAZ5LQ