Skip to content

chore: refactor the API base URL into a constant#135

Merged
nicomiguelino merged 5 commits into
Screenly:masterfrom
nicomiguelino:refactor-api-base-url
Apr 24, 2025
Merged

chore: refactor the API base URL into a constant#135
nicomiguelino merged 5 commits into
Screenly:masterfrom
nicomiguelino:refactor-api-base-url

Conversation

@nicomiguelino

Copy link
Copy Markdown
Collaborator

Description

  • Refactors the API base URL in API calls to reduce code duplication

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have tested my changes on Google Chrome.
  • I have tested my changes on Mozilla Firefox.
  • I added a documentation for the changes I have made (when necessary).

@nicomiguelino
nicomiguelino requested a review from Copilot April 15, 2025 20:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

@iamplugged iamplugged left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might probably better to use the base url as default in callApi implementation, so that you can avoid prepending it everytime.

@nicomiguelino
nicomiguelino merged commit 4b89add into Screenly:master Apr 24, 2025
@nicomiguelino
nicomiguelino deleted the refactor-api-base-url branch April 24, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants