chore(ci): update how formatters and linters are run#137
Merged
nicomiguelino merged 2 commits intoApr 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
README.md:131
- Ensure that the removal of the 'src/' argument is intentional and that run_eslint.sh defaults to linting the correct directories. If this change is expected, consider updating the documentation to clarify the new usage.
$ ./bin/run_eslint.sh
.github/workflows/lint-and-format.yaml:26
- Verify that the removal of the 'src/' parameter in the CI workflow is intended and that the lint process doesn't miss any relevant files. If the new default behavior is correct, update any related documentation to avoid confusion.
./bin/run_eslint.sh
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration by modifying how the formatting and linting scripts are invoked.
- Updated README and GitHub Actions workflow to execute ESLint without the explicit "src/" argument.
- Standardized linting command usage across the documentation and CI workflow.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Updated the ESLint command example to run without the "src/" argument, potentially affecting scope. |
| .github/workflows/lint-and-format.yaml | Changed the ESLint execution in the CI workflow to omit the "src/" argument for consistency. |
Files not reviewed (1)
- package.json: Language not supported
nicomiguelino
marked this pull request as ready for review
April 17, 2025 02:58
iamplugged
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
package.jsonto introduce new scripts/commands likelint:check,lint:fix,format:check, andformat:writeChecklist