Skip to content

chore(ci): update how formatters and linters are run#137

Merged
nicomiguelino merged 2 commits into
Screenly:masterfrom
nicomiguelino:update-linting-and-formatting-pipeline
Apr 24, 2025
Merged

chore(ci): update how formatters and linters are run#137
nicomiguelino merged 2 commits into
Screenly:masterfrom
nicomiguelino:update-linting-and-formatting-pipeline

Conversation

@nicomiguelino

@nicomiguelino nicomiguelino commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

Description

Updates package.json to introduce new scripts/commands like lint:check, lint:fix, format:check, and format:write

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have tested my changes on Google Chrome.
  • I have tested my changes on Mozilla Firefox.
  • I added a documentation for the changes I have made (when necessary).

@nicomiguelino
nicomiguelino requested a review from Copilot April 17, 2025 02:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

README.md:131

  • Ensure that the removal of the 'src/' argument is intentional and that run_eslint.sh defaults to linting the correct directories. If this change is expected, consider updating the documentation to clarify the new usage.
$ ./bin/run_eslint.sh

.github/workflows/lint-and-format.yaml:26

  • Verify that the removal of the 'src/' parameter in the CI workflow is intended and that the lint process doesn't miss any relevant files. If the new default behavior is correct, update any related documentation to avoid confusion.
./bin/run_eslint.sh

@nicomiguelino
nicomiguelino requested a review from Copilot April 17, 2025 02:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI configuration by modifying how the formatting and linting scripts are invoked.

  • Updated README and GitHub Actions workflow to execute ESLint without the explicit "src/" argument.
  • Standardized linting command usage across the documentation and CI workflow.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
README.md Updated the ESLint command example to run without the "src/" argument, potentially affecting scope.
.github/workflows/lint-and-format.yaml Changed the ESLint execution in the CI workflow to omit the "src/" argument for consistency.
Files not reviewed (1)
  • package.json: Language not supported

Comment thread README.md
Comment thread .github/workflows/lint-and-format.yaml
@nicomiguelino
nicomiguelino marked this pull request as ready for review April 17, 2025 02:58
@nicomiguelino
nicomiguelino merged commit ef27956 into Screenly:master Apr 24, 2025
@nicomiguelino
nicomiguelino deleted the update-linting-and-formatting-pipeline branch April 24, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants