Dedupe near-duplicate deploy tests

[nicomiguelino]

Summary

• Folds test_deploy_should_send_correct_requests and test_deploy_with_explicit_app_id_and_no_manifest_id_should_send_correct_requests into a single shared helper, run_deploy_should_send_correct_requests_test(id_in_manifest: bool), called with true and false.
• Addresses the non-blocking nit from Deprecate reading Edge App id from manifest, prefer EDGE_APP_ID env var #315 (review)

Test plan

• cargo build
• cargo test (only known pre-existing unrelated failure: authentication::tests::test_read_token_correct_token_is_returned)
• cargo clippy --all-targets -- -D warnings
• cargo fmt --check

[Copilot]

🟢 Approval recommended

The change is a straightforward test refactor that preserves the same mocked request expectations while removing duplicated code.

Pull request overview

Refactors the edge_app deploy request tests to remove near-duplicate test bodies while preserving coverage of both “app id comes from manifest” and “explicit app id with no manifest id” behaviors.

Changes:

• Introduces a shared helper run_deploy_should_send_correct_requests_test(id_in_manifest: bool) for the deploy-request mock/assert sequence.
• Updates the two existing deploy tests to delegate to the helper with true/false, toggling whether manifest.id is present and whether deploy() is called with an explicit app_id.

File summaries

File	Description
src/commands/edge_app/app.rs	Deduplicates two near-identical deploy tests into a shared helper while keeping both scenarios exercised.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.