Say that a ToolSpec without input_schema is a tool with no arguments - #5
Merged
Conversation
The README describes where a tool schema lives and how argument keys are
derived from its properties, but never says what a spec that omits the
schema does. That is the first edge a consumer meets: a test double built
without an input_schema sends arguments, gets no error, and sees dispatch
called with an empty map.
Measured against a catalog with one schemaless spec, tools/call with
arguments %{"surprise" => "x", "n" => 3}:
advertised inputSchema: %{"additionalProperties" => true,
"properties" => %{}, "type" => "object"}
dispatch received: {:ping, %{}}
additionalProperties is true so validation refuses nothing, and the
permitted key set is derived from properties, which is empty, so every
key is dropped. The behaviour is right; only the documentation was
missing. One line, no code change.
Closes SCR-251.
Signed-off-by: Ayla Croft <aylacroft@proton.me>
HackTuah
force-pushed
the
readme/default-input-schema
branch
from
September 6, 2026 21:46
253ecb4 to
145e9c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One README line, no code change. Closes SCR-251.
ToolSpecdefaultsinput_schemato an open object. The README explained where a schema lives and how argument keys are derived fromproperties, but never what a spec that omits the schema does — which is the first edge a consumer's test double hits.Measured against a catalog holding one schemaless spec,
tools/callwithargumentsof%{"surprise" => "x", "n" => 3}:additionalPropertiesistrue, so validation refuses nothing; the permitted key set comes fromproperties, which is empty, so every key is dropped. The behaviour is coherent — a spec with no schema is a tool with no arguments — and only the documentation was missing.Gate green locally: format, compile, test, credo, reuse, licence files.
Ships in 0.1.1.