test: apply post-merge review feedback from #22, #24, and #27 - #30
Conversation
- close the fixture-server listener before destroying held connections so a reconnecting browser cannot slip a new request past teardown (#24) - honor AGENT_BUNDLE_PACKAGE_PREBUILT in public-api.test.ts so the parallel integration pool never rewrites the shared dist directories (#27) - move packed-release.e2e into the packed suite so `pnpm test` and `check:release` stop running the same long packed-browser suite twice, retiring the now-empty serial integration pool (#22) - reconcile the fidelity ledger with the desktop-only capture interface and drop the retired mobile.png evidence (#22)
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Summary
Addresses the unresolved Codex review findings left on merged PRs #22, #24, and #27 (the #25/#26/#28 threads flag the same issue as #27's):
closeServernow startsserver.close()(stopping the listener) beforecloseAllConnections(), the order Node's HTTP docs prescribe, so a reconnecting browser can't open a fresh connection between the sweep and the close and re-create the teardown hang.public-api.test.tshonorsAGENT_BUNDLE_PACKAGE_PREBUILTlikecli.test.ts, so the parallel integration pool never rewrites the shareddistdirectories mid-run. With the seam set the file drops from a full rootpnpm buildto ~6s.packed-release.e2e.test.tsmoves out of the integration pool intopackedTestFiles/test:packedonly, sopnpm test(CI verify) andcheck:release(CI release-gates) stop running the same long packed-browser suite twice per event. The serial integration pool is empty after the move, sorstest.integration-serial.config.tsand its extratest:integration:runinvocation are retired. Coverage is preserved: release-gates runs on every PR and push.mobile.pngis deleted. Rows citing the removed mobile raster or the pruned 40px hit-target measurement are re-dispositioned honestly per the ledger's own evidence rules.Verification
pnpm typecheck— passpnpm test:unit— pass (117 files, 1658 tests; one unrelated pre-existing flake inruntime-client-surface-proxy.test.tson the first run, clean on rerun and standalone)rstest.integration.config.tstargeted run ofpublic-api.test.ts+mcp-page-app-browser.test.tswith the prebuilt seam — pass (13 tests)