Skip to content

test: apply post-merge review feedback from #22, #24, and #27 - #30

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/post-merge-review-feedback
Aug 29, 2026
Merged

test: apply post-merge review feedback from #22, #24, and #27#30
ScriptedAlchemy merged 1 commit into
mainfrom
fix/post-merge-review-feedback

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

Addresses the unresolved Codex review findings left on merged PRs #22, #24, and #27 (the #25/#26/#28 threads flag the same issue as #27's):

  • fix(tests): destroy browser-held connections before closing fixture servers #24 (comment)closeServer now starts server.close() (stopping the listener) before closeAllConnections(), the order Node's HTTP docs prescribe, so a reconnecting browser can't open a fresh connection between the sweep and the close and re-create the teardown hang.
  • test: prune low-value tests and parallelize the integration pool #27 (comment)public-api.test.ts honors AGENT_BUNDLE_PACKAGE_PREBUILT like cli.test.ts, so the parallel integration pool never rewrites the shared dist directories mid-run. With the seam set the file drops from a full root pnpm build to ~6s.
  • test: prune low-value tests and consolidate slow suites #22 (comment)packed-release.e2e.test.ts moves out of the integration pool into packedTestFiles/test:packed only, so pnpm test (CI verify) and check:release (CI release-gates) stop running the same long packed-browser suite twice per event. The serial integration pool is empty after the move, so rstest.integration-serial.config.ts and its extra test:integration:run invocation are retired. Coverage is preserved: release-gates runs on every PR and push.
  • test: prune low-value tests and consolidate slow suites #22 (comment) — the fidelity ledger now matches the desktop-only capture interface: five 1440×900 captures, no mobile boundary, and the retired mobile.png is deleted. Rows citing the removed mobile raster or the pruned 40px hit-target measurement are re-dispositioned honestly per the ledger's own evidence rules.

Verification

  • pnpm typecheck — pass
  • pnpm test:unit — pass (117 files, 1658 tests; one unrelated pre-existing flake in runtime-client-surface-proxy.test.ts on the first run, clean on rerun and standalone)
  • rstest.integration.config.ts targeted run of public-api.test.ts + mcp-page-app-browser.test.ts with the prebuilt seam — pass (13 tests)

- close the fixture-server listener before destroying held connections so
  a reconnecting browser cannot slip a new request past teardown (#24)
- honor AGENT_BUNDLE_PACKAGE_PREBUILT in public-api.test.ts so the parallel
  integration pool never rewrites the shared dist directories (#27)
- move packed-release.e2e into the packed suite so `pnpm test` and
  `check:release` stop running the same long packed-browser suite twice,
  retiring the now-empty serial integration pool (#22)
- reconcile the fidelity ledger with the desktop-only capture interface and
  drop the retired mobile.png evidence (#22)
@changeset-bot

changeset-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ff9a345

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T05:38:38.092590Z ff9a345 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Aug 29, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@30
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/rsc-runtime@30

commit: ff9a345

@ScriptedAlchemy
ScriptedAlchemy merged commit 5997c55 into main Aug 29, 2026
14 of 16 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/post-merge-review-feedback branch August 29, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant