refactor(runtime): keep process identity API minimal#398
Merged
Conversation
|
This was referenced Jul 9, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged #396.
random_hex_token(bytes)helper and its testprocess_run_id()API used by MCP analyticsWhy
The helper had no production caller and its RNG-failure fallback always returned a 16-character timestamp regardless of the requested byte count, contradicting its documented
2 * bytescontract. Keeping it would publish speculative surface area with an untested failure-path bug.Tests
cargo test --lib runtime_identity: passcargo test --lib mcp::: 183 immediate tests passed; unrelated timer/global-store tests then starved under the concurrent local build load and the run was interrupted