Skip to content

refactor(runtime): keep process identity API minimal#398

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
codex/runtime-identity-api-cleanup
Jul 9, 2026
Merged

refactor(runtime): keep process identity API minimal#398
ScriptedAlchemy merged 1 commit into
masterfrom
codex/runtime-identity-api-cleanup

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

Follow-up to merged #396.

  • remove the unused public random_hex_token(bytes) helper and its test
  • remove comments added only to justify why existing token generators did not call that unused helper
  • retain the actual shared process_run_id() API used by MCP analytics

Why

The helper had no production caller and its RNG-failure fallback always returned a 16-character timestamp regardless of the requested byte count, contradicting its documented 2 * bytes contract. Keeping it would publish speculative surface area with an untested failure-path bug.

Tests

  • cargo test --lib runtime_identity: pass
  • cargo test --lib mcp::: 183 immediate tests passed; unrelated timer/global-store tests then starved under the concurrent local build load and the run was interrupted
  • upstream refactor: shared process run id and random-token minting #396 CI was green before merge; this follow-up only deletes unused code/comments

@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8d57c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy merged commit fe8dfc3 into master Jul 9, 2026
13 of 14 checks passed
This was referenced Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant