Skip to content

fix(hermes): use the user TraceDecay profile#407

Merged
ScriptedAlchemy merged 11 commits into
masterfrom
codex/hermes-user-profile-only
Jul 10, 2026
Merged

fix(hermes): use the user TraceDecay profile#407
ScriptedAlchemy merged 11 commits into
masterfrom
codex/hermes-user-profile-only

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • remove Hermes-home/profile storage routing, CLI flags, MCP schemas, automation bridges, and compatibility fallbacks
  • keep ~/.hermes only as the host plugin/config/transcript source location; runtime data uses the ordinary user-profile project shard
  • migrate legacy Hermes sessions and facts transactionally, including facts-only stores, moved/renamed/symlinked projects, collision detection, idempotent ledgers, and safe install/update cutover

Tests

  • cargo test --lib migrate::hermes
  • cargo test --test agent_suite hermes
  • cargo test --test hermes_suite
  • cargo test --test storage_suite
  • cargo clippy --all-targets --all-features -- -D warnings

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot

changeset-bot Bot commented Jul 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d8ac40f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Cross-session diagnosis (Fable): the Linux/macOS failures are mcp::tools::handlers::tests::test_tool_definitions_complete (mod.rs:988) — a definitions/dispatch registry consistency assertion. Master moved under this branch: #392 registered a new tool (tracedecay_ast_grep_search, unconditionally — no binary gating), so the merge ref's expected tool set differs from what this branch's Hermes-strip removals were counted against. A rebase onto current master (re-running the registry lockstep tests after) should clear it; no fault in the strip itself. Related: the strip inventory from the earlier recalled agent is stored as fact #159 (STRIP vs KEEP split incl. the migrate-inventory StoreRole judgment and the never-constructed StoreKind::HermesProfile) if useful for cross-checking coverage.

🤖 Diagnosis by Claude Code

@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Release blockers from local review:

  • resolve_project_candidate fails moved/symlink aliases on macOS (/var vs /private/var); current macOS migration tests are red.
  • detected_plugin_dirs/uninstall ignore legacy named-profile, HERMES_HOME, and project-local plugins/stores, leaving stale active installs. Removal of special runtime routing still requires one-time discovery/migration/cleanup.
  • copy_memory_facts/copy_memory_feedback/copy_table use silent collision ignores: same-content facts lose source trust/feedback and session/LCM key conflicts can conflate rows. Merge explicitly and record collisions.
  • enable_plugin_config removes the project pin before legacy state.db rows lacking sessions.cwd are imported/routed, making them unrouteable.
  • Non-Windows CI is red: test_tool_definitions_complete expects 102 tools but sees 101.

Please fix and rerun non-Windows CI before merge.

@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/hermes-user-profile-only branch from e2bb151 to 78f915a Compare July 10, 2026 02:41
@ScriptedAlchemy ScriptedAlchemy force-pushed the codex/hermes-user-profile-only branch from 78f915a to 4e3d99e Compare July 10, 2026 02:48
@ScriptedAlchemy ScriptedAlchemy merged commit 78bfbfb into master Jul 10, 2026
13 of 19 checks passed
ScriptedAlchemy added a commit that referenced this pull request Jul 10, 2026
Three-way verification pass after the rebase and external deepening
commits: reconcile remaining stale merge-state claims (#418 released,
#423/#424/#425/#407 merged at base 3567e31; #409 closed-not-merged),
enforce single canonical definitions (DiagnosticEnvelopeV1 -> plan 24,
SanitizationReceiptV1 -> plan 18, CursorPage -> plan 17), fix a stray
non-canonical error code in plan 01, and repair four tables broken by
unescaped pipes in inline code. Lab inventory, budgets, tool counts,
FM-001..103 contiguity, links after the docs/plans move, and PR-letter
namespace all verified clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant