Skip to content

fix(edit): make move_symbol writes race-safe#419

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
codex/move-symbol-write-safety
Jul 10, 2026
Merged

fix(edit): make move_symbol writes race-safe#419
ScriptedAlchemy merged 1 commit into
masterfrom
codex/move-symbol-write-safety

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • reject destination symlink escapes and source/destination inode aliases
  • preserve in-project symlinks while using atomic sibling-renames
  • revalidate both file snapshots before the two-file commit and avoid clobbering concurrent rollback edits
  • use cross-platform same-file identity for hard links

Verification

  • cargo test --lib move_symbol (22 passed)
  • cargo test --test mcp_suite move_symbol (13 passed)
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo fmt --check

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot

changeset-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 109d31c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy ScriptedAlchemy merged commit 66584b4 into master Jul 10, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant