feat: add basic channel implementation - #17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a basic multi-producer, multi-consumer (MPMC) channel implementation for the async runtime, built on top of the heapless crate's MPMC queue. The implementation provides async send/recv operations along with synchronous try_send/try_recv alternatives.
Key changes:
- Adds a new
channelsmodule withProducerandConsumertypes supporting both blocking and non-blocking operations - Introduces
channel!macro for convenient channel creation andspawn_task!macro for task spawning - Updates examples to use fully-qualified paths (e.g.,
ato::Spawnerinstead of importingSpawner)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Exposes the new channels module and adds the spawn_task! macro for spawning tasks with a spawner |
| src/channels.rs | Implements the channel infrastructure with Producer/Consumer types, async futures, and the channel! macro |
| examples/yield.rs | Updates imports to use fully-qualified paths for Spawner and yield_now |
| examples/until_condition.rs | Updates imports to use fully-qualified path for Spawner |
| examples/time.rs | Updates imports to use fully-qualified paths for Spawner and sleep |
| examples/simple.rs | Updates imports to use fully-qualified path for Spawner |
| examples/channels.rs | Adds new example demonstrating channel usage with producer/consumer tasks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.