feat: add spawn! macro to simplify creation of tasks - #27
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new spawn! macro that simplifies task spawning by eliminating the need for explicit error handling. The macro panics when the task queue is full, making it suitable for scenarios where queue overflow is unexpected. The existing spawn_task! macro is retained for cases requiring error handling.
Changes:
- Added new
spawn!macro that panics on spawn failure instead of returning a Result - Updated
spawn_task!macro documentation to clarify when to use each macro variant - Migrated all examples and tests from
spawn_task!to the simplerspawn!macro
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Adds spawn! macro, updates spawn_task! documentation, and converts tests to use new macro |
| examples/yield.rs | Converts from spawn_task! with explicit error handling to spawn! macro |
| examples/time.rs | Converts from spawn_task! with explicit error handling to spawn! macro |
| examples/simple.rs | Converts from spawn_task! with explicit error handling to spawn! macro |
| examples/interval.rs | Converts from spawn_task! with explicit error handling to spawn! macro |
| examples/channels.rs | Converts from spawn_task! with explicit error handling to spawn! macro |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.