fix: Fix release workflow version detection logic #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og sections - Fixed version bump logic to check for actual entries (lines starting with '-') instead of just checking for section headers - Removed empty changelog sections that were causing incorrect major version bump - Now correctly detects that only Added section has entries, resulting in minor bump
- Reverted type aliases to use TypeAlias annotation (typer compatibility) - Added UP040 to ruff ignore rules since typer doesn't support new type syntax - Fixed mypy python_version from incorrect '1.0.0' to '3.11' - Cleaned up CHANGELOG.md formatting
- Moved content from Unreleased to 1.0.0 section - Removed empty subsections - Fixed version comparison links
- Changed version back to 0.1.0 in pyproject.toml and __init__.py - Moved changelog entries back to Unreleased section - Removed 1.0.0 release entry from CHANGELOG.md
- Configure hatchling to read version from src/sprout/__init__.py - Update release workflow to only update __init__.py - Remove version duplication between pyproject.toml and __init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The release workflow was detecting empty
### Removedsection as a major version bump, resulting in version 1.0.0 instead of the expected 0.2.0.Solution
Updated version detection logic in
.github/workflows/release.yml:-) within each sectionCleaned up CHANGELOG.md:
Testing
After merge, the next release should correctly detect:
### Addedsection has entries → Minor version bump (0.1.0 → 0.2.0)🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com