docs: extend PRD & ADR set (0010 BLAKE3-default, 0011 duckdb MSVC floor) - #2
Merged
Conversation
…PRD refs Reverse-write two load-bearing decisions not yet captured: - ADR-0010: BLAKE3 is the zero-argument default (src/cli.rs:18) while every hashdeep algorithm stays selectable — the superset holds via flags, not the default. - ADR-0011: floor duckdb-output at DuckDB 1.5.5 (crate 1.10505.0); MSVC 14.51 removed stdext::checked_array_iterator, breaking the bundled fmt in 1.10501.0 on windows-latest (commit 4233c08, branch fix/windows-ci-duckdb-msvc-fmt). PRD Related-Decisions table + inline cross-refs updated (0001-0011). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
h4x0r
added a commit
that referenced
this pull request
Jul 27, 2026
…ision with open PR #2's 0010/0011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blazehash already carries a genuine, high-quality reverse-written
docs/PRD.mdand ADRs 0001-0009 (dated 2026-07-24). Per the fleet PRD & ADR standard's "extend, don't duplicate" rule, this PR adds the two load-bearing decisions that were not yet captured, rather than rewriting the existing set.New ADRs
blake3(src/cli.rs:18,:488), leading with the product's headline differentiator; every hashdeep algorithm stays selectable via-c, so compatibility holds through the flags, not the default. The one deliberate divergence: a workflow relying on hashdeep's implicit MD5+SHA-256 default must name them (-c md5,sha256).duckdb-outputat DuckDB 1.5.5 (crate 1.10505.0) for the MSVC 14.51 fmt break. MSVC 14.51 (VS 2026, nowwindows-latest) removedstdext::checked_array_iterator; the bundled fmt induckdb1.10501.0 (engine 1.5.1) still used it, breaking thelibduckdb-sysC++ compile with C2653. DuckDB PR #23261/#23239 dropped the usage in engine 1.5.5. Root-cause fix (bump the floor), not a Windows test skip. Landed onfix/windows-ci-duckdb-msvc-fmt(commit 4233c08); the ADR records the state-note thatmain's manifest still reads the pre-fix version until both branches merge.PRD
Minimal extension only: ADR range
0001-0011, two new rows in the Related-Decisions table, and two inline cross-refs (BLAKE3-default; duckdb floor). The existing PRD prose is unchanged.Both new ADRs are grounded in a same-session read of
Cargo.toml,src/cli.rs,src/format/duckdb_fmt.rs, git history, and the verified upstream cause.mkdocs.ymlalready excludesdecisions/, somkdocs build --strictis unaffected.🤖 Generated with Claude Code