Add textContent attribute support to HtmlUnitDriver#1205
Add textContent attribute support to HtmlUnitDriver#1205Toilal wants to merge 1 commit intoSeleniumHQ:masterfrom
Conversation
|
can you add a test using this to https://github.com/SeleniumHQ/selenium/blob/master/java/client/test/org/openqa/selenium/ElementAttributeTest.java and ignore IE < 9. Everything else should work for getting textContent |
|
to ignore IE < 9 add this line at the start of the test: assumeFalse("IE before 9 doesn't handle textContent attribute", TestUtilities.isOldIe(driver)); The pages.simpleTestPage used in some of the tests is this one: |
|
also... have you signed the CLA? :) |
|
I've just signed them as "ALVERGNAT Rémi" as full name. I'll have a look to
|
80d8605 to
4140a3e
Compare
4140a3e to
81e636c
Compare
|
Test added, and CLA signed using toilal.dev@gmail.com mail adress (same as git email) |
|
thanks! merged as 0108b8b |
To be consistent with WebRemoteDriver, textContent attribute should retrieve textContent of the underlying DOM Node.