New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textContent attribute support to HtmlUnitDriver #1205

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Toilal
Contributor

Toilal commented Oct 30, 2015

To be consistent with WebRemoteDriver, textContent attribute should retrieve textContent of the underlying DOM Node.

@lukeis

This comment has been minimized.

Show comment
Hide comment
@lukeis

lukeis Oct 30, 2015

Member

can you add a test using this to https://github.com/SeleniumHQ/selenium/blob/master/java/client/test/org/openqa/selenium/ElementAttributeTest.java

and ignore IE < 9. Everything else should work for getting textContent

Member

lukeis commented Oct 30, 2015

can you add a test using this to https://github.com/SeleniumHQ/selenium/blob/master/java/client/test/org/openqa/selenium/ElementAttributeTest.java

and ignore IE < 9. Everything else should work for getting textContent

@lukeis

This comment has been minimized.

Show comment
Hide comment
@lukeis

lukeis Oct 30, 2015

Member

to ignore IE < 9 add this line at the start of the test:

assumeFalse("IE before 9 doesn't handle textContent attribute", TestUtilities.isOldIe(driver));

The pages.simpleTestPage used in some of the tests is this one:
https://github.com/SeleniumHQ/selenium/blob/master/common/src/web/simpleTest.html

Member

lukeis commented Oct 30, 2015

to ignore IE < 9 add this line at the start of the test:

assumeFalse("IE before 9 doesn't handle textContent attribute", TestUtilities.isOldIe(driver));

The pages.simpleTestPage used in some of the tests is this one:
https://github.com/SeleniumHQ/selenium/blob/master/common/src/web/simpleTest.html

@lukeis

This comment has been minimized.

Show comment
Hide comment
@lukeis

lukeis Oct 30, 2015

Member

also... have you signed the CLA? :)

Member

lukeis commented Oct 30, 2015

also... have you signed the CLA? :)

@Toilal

This comment has been minimized.

Show comment
Hide comment
@Toilal

Toilal Oct 30, 2015

Contributor

I've just signed them as "ALVERGNAT Rémi" as full name. I'll have a look to
include the test.
Le 30 oct. 2015 5:31 PM, "Luke Inman-Semerau" notifications@github.com a
écrit :

also... have you signed the CLA
https://spreadsheets.google.com/spreadsheet/viewform?hl=en_US&formkey=dFFjXzBzM1VwekFlOWFWMjFFRjJMRFE6MQ#gid=0?
:)


Reply to this email directly or view it on GitHub
#1205 (comment).

Contributor

Toilal commented Oct 30, 2015

I've just signed them as "ALVERGNAT Rémi" as full name. I'll have a look to
include the test.
Le 30 oct. 2015 5:31 PM, "Luke Inman-Semerau" notifications@github.com a
écrit :

also... have you signed the CLA
https://spreadsheets.google.com/spreadsheet/viewform?hl=en_US&formkey=dFFjXzBzM1VwekFlOWFWMjFFRjJMRFE6MQ#gid=0?
:)


Reply to this email directly or view it on GitHub
#1205 (comment).

@Toilal

This comment has been minimized.

Show comment
Hide comment
@Toilal

Toilal Oct 30, 2015

Contributor

Test added, and CLA signed using toilal.dev@gmail.com mail adress (same as git email)

Contributor

Toilal commented Oct 30, 2015

Test added, and CLA signed using toilal.dev@gmail.com mail adress (same as git email)

@lukeis

This comment has been minimized.

Show comment
Hide comment
@lukeis

lukeis Oct 30, 2015

Member

thanks! merged as 0108b8b

Member

lukeis commented Oct 30, 2015

thanks! merged as 0108b8b

@lukeis lukeis closed this Oct 30, 2015

@Toilal Toilal deleted the Toilal:htmlunit-text-content branch Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment