Skip to content

Add textContent attribute support to HtmlUnitDriver#1205

Closed
Toilal wants to merge 1 commit intoSeleniumHQ:masterfrom
Toilal:htmlunit-text-content
Closed

Add textContent attribute support to HtmlUnitDriver#1205
Toilal wants to merge 1 commit intoSeleniumHQ:masterfrom
Toilal:htmlunit-text-content

Conversation

@Toilal
Copy link
Copy Markdown
Contributor

@Toilal Toilal commented Oct 30, 2015

To be consistent with WebRemoteDriver, textContent attribute should retrieve textContent of the underlying DOM Node.

@lukeis
Copy link
Copy Markdown
Member

lukeis commented Oct 30, 2015

can you add a test using this to https://github.com/SeleniumHQ/selenium/blob/master/java/client/test/org/openqa/selenium/ElementAttributeTest.java

and ignore IE < 9. Everything else should work for getting textContent

@lukeis
Copy link
Copy Markdown
Member

lukeis commented Oct 30, 2015

to ignore IE < 9 add this line at the start of the test:

assumeFalse("IE before 9 doesn't handle textContent attribute", TestUtilities.isOldIe(driver));

The pages.simpleTestPage used in some of the tests is this one:
https://github.com/SeleniumHQ/selenium/blob/master/common/src/web/simpleTest.html

@lukeis
Copy link
Copy Markdown
Member

lukeis commented Oct 30, 2015

also... have you signed the CLA? :)

@Toilal
Copy link
Copy Markdown
Contributor Author

Toilal commented Oct 30, 2015

I've just signed them as "ALVERGNAT Rémi" as full name. I'll have a look to
include the test.
Le 30 oct. 2015 5:31 PM, "Luke Inman-Semerau" notifications@github.com a
écrit :

also... have you signed the CLA
https://spreadsheets.google.com/spreadsheet/viewform?hl=en_US&formkey=dFFjXzBzM1VwekFlOWFWMjFFRjJMRFE6MQ#gid=0?
:)


Reply to this email directly or view it on GitHub
#1205 (comment).

@Toilal Toilal force-pushed the htmlunit-text-content branch from 80d8605 to 4140a3e Compare October 30, 2015 20:29
@Toilal Toilal force-pushed the htmlunit-text-content branch from 4140a3e to 81e636c Compare October 30, 2015 20:33
@Toilal
Copy link
Copy Markdown
Contributor Author

Toilal commented Oct 30, 2015

Test added, and CLA signed using toilal.dev@gmail.com mail adress (same as git email)

@lukeis
Copy link
Copy Markdown
Member

lukeis commented Oct 30, 2015

thanks! merged as 0108b8b

@lukeis lukeis closed this Oct 30, 2015
@Toilal Toilal deleted the htmlunit-text-content branch November 23, 2015 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants