Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd textContent attribute support to HtmlUnitDriver #1205
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukeis
Oct 30, 2015
Member
can you add a test using this to https://github.com/SeleniumHQ/selenium/blob/master/java/client/test/org/openqa/selenium/ElementAttributeTest.java
and ignore IE < 9. Everything else should work for getting textContent
|
can you add a test using this to https://github.com/SeleniumHQ/selenium/blob/master/java/client/test/org/openqa/selenium/ElementAttributeTest.java and ignore IE < 9. Everything else should work for getting textContent |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
lukeis
Oct 30, 2015
Member
to ignore IE < 9 add this line at the start of the test:
assumeFalse("IE before 9 doesn't handle textContent attribute", TestUtilities.isOldIe(driver));
The pages.simpleTestPage used in some of the tests is this one:
https://github.com/SeleniumHQ/selenium/blob/master/common/src/web/simpleTest.html
|
to ignore IE < 9 add this line at the start of the test: assumeFalse("IE before 9 doesn't handle textContent attribute", TestUtilities.isOldIe(driver)); The pages.simpleTestPage used in some of the tests is this one: |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
also... have you signed the CLA? :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Toilal
Oct 30, 2015
Contributor
I've just signed them as "ALVERGNAT Rémi" as full name. I'll have a look to
include the test.
Le 30 oct. 2015 5:31 PM, "Luke Inman-Semerau" notifications@github.com a
écrit :
also... have you signed the CLA
https://spreadsheets.google.com/spreadsheet/viewform?hl=en_US&formkey=dFFjXzBzM1VwekFlOWFWMjFFRjJMRFE6MQ#gid=0?
:)—
Reply to this email directly or view it on GitHub
#1205 (comment).
|
I've just signed them as "ALVERGNAT Rémi" as full name. I'll have a look to
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Toilal
Oct 30, 2015
Contributor
Test added, and CLA signed using toilal.dev@gmail.com mail adress (same as git email)
|
Test added, and CLA signed using toilal.dev@gmail.com mail adress (same as git email) |
This was referenced Oct 30, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
thanks! merged as 0108b8b |
Toilal commentedOct 30, 2015
To be consistent with WebRemoteDriver, textContent attribute should retrieve textContent of the underlying DOM Node.