Add new and old capabilities/properties support to InternetExplorerDriver.#41
Closed
alex-savchuk wants to merge 1 commit intoSeleniumHQ:masterfrom
alex-savchuk:upstream
Closed
Add new and old capabilities/properties support to InternetExplorerDriver.#41alex-savchuk wants to merge 1 commit intoSeleniumHQ:masterfrom alex-savchuk:upstream
alex-savchuk wants to merge 1 commit intoSeleniumHQ:masterfrom
alex-savchuk:upstream
Conversation
Support all capabilities/properties for ie driver
Contributor
Author
|
Closed due argument names are changed. |
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
The original fix for SeleniumHQ#36 was done in the Reliability layer, breaking separation of concerns between the layers of the stack. Instead of determining and notifying the original request about a timeout from within the Reliability layer, we now copy all MessageObservers of the original request to the individual blockwise requests in the Blockwise layer. This way, the Reliability layer can fall back to its original behavior of simply timing out the request at hand without checking if it is a blockwise request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new and old capabilities/properties support to InternetExplorerDriver.
What's done:
** no changes in method access
** add max customized constructor
** add support for all IEDriverServer-related capabilities
This fixes #4525 and partially #4287 issues.
the CLA as Alex Savchuk on behalf of Mail.Ru has been signed.