[updated] Add new and old capabilities/properties support to InternetExplorerDrive...#50
Closed
alex-savchuk wants to merge 3 commits intoSeleniumHQ:masterfrom
alex-savchuk:ie_driver_java
Closed
[updated] Add new and old capabilities/properties support to InternetExplorerDrive...#50alex-savchuk wants to merge 3 commits intoSeleniumHQ:masterfrom alex-savchuk:ie_driver_java
alex-savchuk wants to merge 3 commits intoSeleniumHQ:masterfrom
alex-savchuk:ie_driver_java
Conversation
…iver. Add new and old capabilities/properties support to InternetExplorerDriver.
update changes according to commentaries
update changes according to commentaries
Contributor
Author
|
Some comments for last commit:
|
Contributor
Author
|
Hm. About removing guard from setupProx() (what is equal to parmanent instanciating of WindowsProxyManager) - need to discuss will be moved proxy code into browser driver or not. depnd on it need to enable or disable this guard, i think. |
Contributor
Author
|
Implemented in c4d3038 |
corevo
added a commit
to applitools/selenium
that referenced
this pull request
Dec 11, 2017
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new and old capabilities/properties support to InternetExplorerDriver.
Updated to support changes in arguments names etc.
What's done:
This PR fixes #4525 and partially #4287 issues.
the CLA as Alex Savchuk on behalf of Mail.Ru has been signed.