Wheel examples #1010
Closed
Wheel examples #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, also, the JavaScript & the Kotlin aren't implemented for this because I wasn't sure what those needed to look like. |
|
Do I need to move this out of draft to get it to deploy a preview? |
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
alaahong
reviewed
May 17, 2022
| + "return f<window.pageYOffset+window.innerHeight&&t<window.pageXOffset+window.innerWidth&&f+n>\n" | ||
| + "window.pageYOffset&&t+o>window.pageXOffset"; | ||
|
|
||
| return (boolean) ((JavascriptExecutor) driver).executeScript(script, element); |
There was a problem hiding this comment.
executeScript will return Boolean as Object, seems no need to convert as boolean?
|
I like the badges idea, but there is no need to implement this on our own. Docsy uses Bootstrap, so you can use their Badges (https://getbootstrap.com/docs/4.6/components/badge/) and combine it with a Tooltip (https://getbootstrap.com/docs/4.6/components/tooltips/). |
|
Getting rolled into #1031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Draft because:
This PR is to show off demo code for what scrolling implementation looks like with the above PR
Also, probably should figure out if we like the badges and do them the right way with shortcodes and such if we like them. @diemol what do you think of the "badges" in this PR?