Skip to content

Chinese version translated/翻译了中文版本 #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Chinese version translated/翻译了中文版本 #1057

wants to merge 2 commits into from

Conversation

@zhiquanchi
Copy link

@zhiquanchi zhiquanchi commented Jun 24, 2022 •
edited
Loading

Chinese version/中文版本

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jun 24, 2022 •
edited
Loading

✅ Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit ffa88c2
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62b6cd91b8a9060008f7a4f9
😎 Deploy Preview https://deploy-preview-1057--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@diemol diemol requested a review from alaahong June 24, 2022 11:32
@diemol
Copy link
Member

diemol commented Jun 24, 2022

Can you please sign the CLA?

alaahong
alaahong reviewed Jun 24, 2022
View reviewed changes
...ite_and_docs/content/documentation/webdriver/bidirectional/bidi_api_remotewebdriver.zh-cn.md Outdated
title: "RemoteWebDriver BiDirectional API"
linkTitle: "RemoteWebDriver BiDi API"
title: "远程网络驱动 双向 API（RemoteWebDriver BiDirectional API）"
linkTitle: "远程网络驱动 BiDi API"
Copy link
Member

@alaahong alaahong Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the WebDriver as a Proper Noun ？

alaahong
alaahong reviewed Jun 24, 2022
View reviewed changes
...ite_and_docs/content/documentation/webdriver/bidirectional/bidi_api_remotewebdriver.zh-cn.md Outdated
{{< /tabpane >}}

## Network Interception
## 监听网络 （Network Interception）
Copy link
Member

@alaahong alaahong Jun 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not monitor only.

Copy link
Author

@zhiquanchi zhiquanchi Jun 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change then translation.I think should use '截网侦察'

@alaahong
Copy link
Member

alaahong commented Jun 24, 2022

Thanks for your first contribution. Just leave some comments, please feel free to discuss.
Generally, it's the "Improved translation", you should keep the wording under same translation in one post, and meanwhile, the conversion is better to avoid long sentence in one line. At last, keep original format(e.g. command) and punctuation(e.g. half-width symbol) is friend to validate the layout.

@zhiquanchi
Modified some translations
ffa88c2 
Modified some translations。
@diemol diemol requested a review from alaahong June 28, 2022 15:56
alaahong
alaahong reviewed Jun 29, 2022
View reviewed changes
...ite_and_docs/content/documentation/webdriver/bidirectional/bidi_api_remotewebdriver.zh-cn.md
The following examples demonstrate how to leverage BiDi APIs with [Remote WebDriver](/documentation/webdriver/remote_webdriver/).

## Register Basic Auth
下面的例子显示如何使用 [Remote WebDriver](/documentation/webdriver/remote_webdriver/).
Copy link
Member

@alaahong alaahong Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is BiDi APIs ?

alaahong
alaahong reviewed Jun 29, 2022
View reviewed changes
...ite_and_docs/content/documentation/webdriver/bidirectional/bidi_api_remotewebdriver.zh-cn.md
## 监听控制台日志事件 （Listen to `console.log` events）

Listen to the `console.log` events and register callbacks to process the event.
监听 console. log 事件并注册回调以处理该事件。
Copy link
Member

@alaahong alaahong Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a code , please keep format as previous mentioned

alaahong
alaahong requested changes Jun 29, 2022
View reviewed changes
Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost are fine, only need aware the missed parts as mentioned.

alaahong
alaahong requested changes Aug 7, 2022
View reviewed changes
Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, will you do the post commit to avoid impact original description and code segment?

@zhiquanchi zhiquanchi closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaahong alaahong alaahong requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiquanchi @CLAassistant @diemol @alaahong