Skip to content

Conversation

@jasonren0403
Copy link
Contributor

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Update Element information document and do some little improvement

Motivation and Context

help zh-cn users understand better

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Nov 5, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit d03100c
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6373bcca4e7a5c000861dc3e
😎 Deploy Preview https://deploy-preview-1214--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@diemol diemol requested a review from alaahong November 9, 2022 15:21
Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to add original author un-synced parts here (isEnabled, Size and Position, Text Content...), actually I really didn't realize the new content in English page.
But, why you re-translated all page? seems no big changed in existing content, but you change here and there.
And meanwhile, please follow contribution rule for new content .
https://www.selenium.dev/documentation/about/contributing/#step-4-commit

@diemol diemol requested a review from alaahong November 13, 2022 21:29
Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost content is readable and updated.
But seems you didn't mention the content which you overwrite, please take care of attribute and property part, you replace with highlight part with your owned thought...

I'm fine with other parts if Jason could update the last part.

…rmation.zh-cn.md

Co-authored-by: Jason Ren <40999116+jasonren0403@users.noreply.github.com>
Copy link
Member

@alaahong alaahong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks~

@diemol diemol merged commit 9ba7b24 into SeleniumHQ:trunk Nov 15, 2022
selenium-ci added a commit that referenced this pull request Nov 15, 2022
* docs(zh-cn): update elements/information

* Add back "Is Enabled" part

* try wrap all line into 72 columns

* Update website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md

* Update website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md

Co-authored-by: Jason Ren <40999116+jasonren0403@users.noreply.github.com>

Co-authored-by: ian zhang <ian.zhangzhe@gmail.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

[deploy site] 9ba7b24
@jasonren0403 jasonren0403 deleted the patch-1 branch November 16, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants