-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove driver managers #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove driver managers #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2049c19 to
fc63e5b
Compare
fc63e5b to
fc947d9
Compare
diemol
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @titusfortner!
selenium-ci
added a commit
that referenced
this pull request
Nov 8, 2022
* update ruby code to remove extra driver manager code * update python code to remove extra driver manager code * update java code to remove extra driver manager code * allow using local packages to test dotnet examples * update dotnet code to remove extra driver manager code * update examples workflows * update internet explorer settings for latest IE Driver * fix tests to get passing * update references to github example code from removing selenium manager references * link to pom in project * add working gradle build to java examples * update library installation docs to refer to versions in examples code [deploy site] 66db4ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all extra references to driver managers and tidies up examples and references to examples.
It also gets all example code passing for Se 4.6.
Further optimization possible once Internet Explorer is included in Selenium Managers