-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update remote_webdriver_client.en.md #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
| {{< / code-panel >}} | ||
| {{< code-panel language="kotlin" >}} | ||
| driver.setFileDetector(new LocalFileDetector()) | ||
| driver.fileDetector = LocalFileDetector() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @marcus-rp,
Good catch.
Can you please update code for other translated pages too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do I do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the same directory you can find more files with the same name but a different suffixes... Those are the translations. Please also change the code in those files.
Don’t forget to sign the CLA please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marcus-rp, thank you for your PR. However please have a look at the previous comments and to our contribution guidelines.
|
hi @marcus-rp , Thanks for providing the PR. As the PR gone stale now, I've updated the sample code in PR #160 |
|
Replaced by #160 |
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist