Skip to content

Conversation

@Madh93
Copy link
Contributor

@Madh93 Madh93 commented Jan 1, 2020

Description

Fixed SearchContext url in locating_elements post in getting_started_with_webdriver section for EN and DE documentation to avoid 404:

Screenshot_20200101_111000

Motivation and Context

It avoids 404 url.

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @Madh93, thanks!

@diemol diemol merged commit 3d29a0e into SeleniumHQ:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants