-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Correct wrong file path in options to provide the right browser version ruby example #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
|
PR Description updated to latest commit (fe4bb8c)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code SuggestionsNo code suggestions found for PR. |
|
Hi @harsha509 this small fix provides better examples on options while I continue working on my separate PR to add examples to http://localhost:60031/documentation/webdriver/drivers/http_client/ I will push it after this changes are merged :) thank you for the help |
|
Hi @aguspe , Could you please complete checklist above ? Thanks, |
diemol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @aguspe!
Hi @harsha509 and @diemol thank you for the approval, I updated the checklist now, have a nice evening! |
User description
Description
While creating #1679 I accidentally mapped the wrong path to the options example, this PR fixes that path
Motivation and Context
It's important to provide Selenium users with high-quality examples in the docs so they can use it in the best possible way, right now the example for the browser version looks like this:
Which is not helpful for selenium users
Types of changes
Checklist
Type
documentation
Description
options_spec.rb) improving the accuracy and usefulness of the documentation.Changes walkthrough
options.en.md
Fix Incorrect Ruby Example Path in English Documentationwebsite_and_docs/content/documentation/webdriver/drivers/options.en.md
service_spec.rbtooptions_spec.rb.options.ja.md
Update Ruby Example Path in Japanese Documentationwebsite_and_docs/content/documentation/webdriver/drivers/options.ja.md
service_spec.rbtooptions_spec.rb.options.pt-br.md
Correct Ruby Example Path in Brazilian Portuguese Documentationwebsite_and_docs/content/documentation/webdriver/drivers/options.pt-br.md
service_spec.rbtooptions_spec.rb.options.zh-cn.md
Update Ruby Example Path in Chinese Documentationwebsite_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md
service_spec.rbtooptions_spec.rb.