Skip to content

Conversation

@ant0x00
Copy link

@ant0x00 ant0x00 commented Feb 7, 2020

update incorrect translate.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

update incorrect translate.
@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ant0x00 ,

Checked in G-translate.PR Looks good to me.

But, Can you please sign the CLA agreement to get this PR merged.

Thanks,
Harsha

@harsha509 harsha509 mentioned this pull request Feb 14, 2020
6 tasks
@harsha509
Copy link
Member

Hi @ant0x00,

Thanks for the PR. As this PR went stale, the changes will be committed as part of PR #229

Regards,
Harsha

@diemol
Copy link
Member

diemol commented Feb 14, 2020

Replaced by #229, thank you @harsha509!

@diemol diemol closed this Feb 14, 2020
diemol added a commit that referenced this pull request Feb 14, 2020
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants