Skip to content

Add Japanese translation of "Grid" #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2020
Merged

Add Japanese translation of "Grid" #226

merged 2 commits into from
Feb 14, 2020

Conversation

@kzhirata
Copy link
Contributor

@kzhirata kzhirata commented Feb 14, 2020 •
edited
Loading

Description

This PR contains new Japanese translation of Grid:

  • grid/_index.ja.md
  • grid/components_of_a_grid.ja.md
  • grid/purposes_and_main_functionalities.ja.md
  • grid/setting_up_your_own_grid.ja.md
  • grid/when_to_use_grid.ja.md

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@kzhirata
Add Japanese translation of "Grid"
671fffe 
- grid/_index.ja.md
- grid/components_of_a_grid.ja.md
- grid/purposes_and_main_functionalities.ja.md
- grid/setting_up_your_own_grid.ja.md
- grid/when_to_use_grid.ja.md
@kzhirata kzhirata requested a review from diemol February 14, 2020 06:59
harsha509
harsha509 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

diemol
diemol approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kzhirata!

@diemol diemol merged commit 2b78c55 into SeleniumHQ:master Feb 14, 2020
@kzhirata kzhirata deleted the grid branch February 14, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

@harsha509 harsha509 harsha509 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzhirata @diemol @harsha509