Skip to content

Add: Adding content to page load strategy #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 2, 2020
Merged

Add: Adding content to page load strategy #259

merged 5 commits into from
Mar 2, 2020

Conversation

@harsha509
Copy link
Member

@harsha509 harsha509 commented Feb 24, 2020 •
edited
Loading

Description

Adding info on document.readyState and pageLoadStrategy behaviour for SPA.

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

diemol
diemol requested changes Feb 29, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509 for the PR, I left a few comments, could you please have a look?

@harsha509
Modify: Updating content for pageLoadStrategy as suggested
c73e744 
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
@harsha509 harsha509 requested a review from diemol March 2, 2020 09:37
@harsha509
Modify: Renaming webdriver to WebDriver
28ef495 
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
diemol
diemol approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harsha509!

harsha509 and others added 2 commits March 2, 2020 15:15
@diemol diemol merged commit 512c2c7 into SeleniumHQ:master Mar 2, 2020
@harsha509 harsha509 deleted the page_load_strategy branch March 2, 2020 10:41
@kzhirata kzhirata mentioned this pull request Mar 3, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harsha509 @diemol