-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
grid_documentation_changes #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changing the grid introduction line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @rahuljhakant,
I've suggested a few changes. Also, can you please sure to do changes in other translated pages too.
Thanks,
Harsha
| of learning Selenium script syntax. | ||
|
|
||
| ## Grid | ||
| Selenium Grid is a feature in Selenium that allows you to run test cases in different machines across different platforms. The control of triggering the test cases is on the local machine, and when the test cases are triggered, they are automatically executed by the remote machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rahuljhakant ,
Thanks for the PR. Can you please make sure to have a line width of 70-80
Thanks,
Harsha
changes LGTM Co-Authored-By: Sri Harsha <Harsha509@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes are fine.
| ## Grid | ||
| Selenium Grid is a feature in Selenium that allows you to run test cases in different machines across different platforms. The control of triggering the test cases is on the local machine, and when the test cases are triggered, they are automatically executed by the remote machine | ||
| Selenium Grid allows you to run test cases in different machines across different platforms. | ||
| The control of triggering the test cases is on the local end, and when the test cases are triggered, they are automatically executed by the remote end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rahuljhakant ,
Thanks for the PR. There are couple of changes required to get this pr merged.
-
Limit each line with max of 70-80 characters in line width. For example
this line 'The control of triggering the test cases is on the local end, and when the test cases are triggered, they are' contains 109 chars, you can spilt into two lines -
The changes are done for only english version document. Still there are 7 translated pages (french, de, zh-ch, ko, nl etc) the same text changes should be done in those .md pages too.
Please let us know if you still need help.
Regards,
Harsha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harsha509 Now I got your point. I will do the translations for all the languages and also Limit each line with a max of 70-80 characters in line width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahuljhakant could you please make the changes in the other language files which are still in English?
|
Hi @rahuljhakant, Did you get a chance to look into the changes suggested by @diemol ? Thanks, |
|
Rahul Kant Jha seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Closing this PR as I'm facing the licensing issue. |
Changing the grid introduction line
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist