Skip to content

Add translation for page_object_models.zh-cn.md #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2020
Merged

Add translation for page_object_models.zh-cn.md #341

merged 4 commits into from
Mar 20, 2020

Conversation

@Ymangz
Copy link
Contributor

@Ymangz Ymangz commented Mar 19, 2020 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add translation for page_object_models.zh-cn.md

Motivation and Context

Add translation for page_object_models.zh-cn.md

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.
    i can't git clone this repository，because there is a fire wall between china and github

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

harsha509
harsha509 requested changes Mar 19, 2020
View reviewed changes
docs_source_files/content/guidelines_and_recommendations/page_object_models.zh-cn.md Outdated
First, consider an example, typical of test automation, that does not use a
page object:

PO（page objec）设计模式是一种易于维护和减少代码的设计模式 ，在自动化中已经变得流行。在自动化测试中，PO对象是作为一个与页面交互的接口。 测试中需要与页面的UI进行交互时，便调用该PO对象的方法。这样做的好处是，所有UI中的改变支持都位于同一个位置。如果页面的UI发生了更改，但是测试用例本身不需要更改，只需更改PO中的代码即可。
Copy link
Member

@harsha509 harsha509 Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @ymang714549348,

Thanks for the PR. Can you please make sure to have a line with a max of 70-80 characters. You can spilt into multiple lines if possible.

Thanks,
Harsha

Copy link
Contributor Author

@Ymangz Ymangz Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spilted it inyo multiple lines

Copy link
Contributor Author

@Ymangz Ymangz Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry,my problem, i will pull the whole repository,and run it ,but it will take some times

Copy link
Member

@alaahong alaahong Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ymangz,
How about the punctuation？Is that better if we keep the format in whole page?
Seems there are full width character with different styles of external space in your translated text.
e.g.

口。 测

式 ，在

法。这

Copy link
Contributor Author

@Ymangz Ymangz Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will modify this to like other page of translated

@Ymangz
add translate for page_object_models.zh-cn.md
405b20f 
page_object_models.zh-cn.md
spilt into multiple line
diemol
diemol requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @Ymangz, could you please make sure each line does not exceed the 70-80 characters limit?

@alaahong
Copy link
Member

alaahong commented Mar 19, 2020

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add translation for page_object_models.zh-cn.md

Motivation and Context

Add translation for page_object_models.zh-cn.md

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.
    ** i can't git clone this repository，because there is a fire wall between china and github**

Just leave a comment.

For seleniumhq.github.io , you can directly clone by git command. I didn't block by greatwall via internet.
For hugo, you can install as the official document --> https://gohugo.io/getting-started/installing/

@Ymangz
add translate to page_object_models.zh-cn.md
e2c3884 
add translate to page_object_models.zh-cn.md , I have build on my computer. and the max line is < 70
@Ymangz
Copy link
Contributor Author

Ymangz commented Mar 20, 2020

I have run it in my computer
image
image
image

diemol
diemol approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Ymangz! Welcome to the project!

@diemol diemol merged commit 9227bc1 into SeleniumHQ:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaahong alaahong alaahong left review comments

@harsha509 harsha509 harsha509 requested changes

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ymangz @CLAassistant @alaahong @diemol @harsha509