Skip to content

Conversation

@diemol
Copy link
Member

@diemol diemol commented Mar 19, 2020

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

@harsha509 has been contributing massively to the Selenium official site and docs, and he has also manifested interest to be part of the committers team.

Description

Adding @harsha509 to the structure page where all the committers are shown, thank you @harsha509

Motivation and Context

To recognize someone who is doing a lot for the Selenium project and the community.

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Before:
image
After:
image

Copy link
Member

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heartily endorsed.

@diemol diemol merged commit 26eb76b into master Mar 20, 2020
@diemol diemol deleted the add-Harsha509-as-a-committer branch March 20, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants